302694 - Show multiple bugs emits errors about addReplyLink missing

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Teemu Mannermaa (:wicked)]

When multiple bugs is shown using either Long Format or Format For Printing
button/link there's one JavaScript error per bug shown. This happens because
JavaScript function addReplyLink is called but it isn't defined.

Comment 1

[Ingo Nolden]

Attachment: Modified comments.html.tmpl

I've noticed the same problem in my installation (2.20rc2).
The workaround for me was to add
  [% IF mode == "edit" %] ... [% END %]
around the lines
		  <script type="text/javascript"><!--
		  addReplyLink(0);
		//--></script>
I don't know if this is the right solution, but it works for me.

Comment 2

[Marc Schumann [:Wurblzap]]

*** Bug 318134 has been marked as a duplicate of this bug. ***

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.0 in unified format

Ingo's variant
 - unrotted
 - for HEAD (doesn't apply to the branch, unfortunately)
 - with [%%] so that there is no whitespace between the reply link and the
   preceding  

Comment 4

[Frédéric Buclin]

Comment on attachment 204469 [details] [diff] [review]
Patch 1.0 in unified format

Nice catch! My Javascript console was full of this error message.

Please backport it to 2.20. 2.18 is not affected (the culprit is bug 199048 which landed on 2.19).

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.0 for the 2.20 branch

Comment 6

[Frédéric Buclin]

Comment on attachment 204864 [details] [diff] [review]
Patch 1.0 for the 2.20 branch

r=LpSolit

Comment 7

[Marc Schumann [:Wurblzap]]

Thanks, Ingo!

Tip:
Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v  <--  comments.html.tmpl
new revision: 1.24; previous revision: 1.23
done

2.20 Branch:
Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v  <--  comments.html.tmpl
new revision: 1.18.2.2; previous revision: 1.18.2.1
done

Comment 8

[Frédéric Buclin]

*** Bug 322745 has been marked as a duplicate of this bug. ***