Closed
Bug 302706
Opened 20 years ago
Closed 20 years ago
[FIXr]Leak radio visitors through shutdown
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Keywords: fixed1.8, memory-leak)
Attachments
(1 file)
|
6.51 KB,
patch
|
jst
:
review+
jst
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
We never release some static pointers...
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #191004 -
Flags: superreview?(jst)
Attachment #191004 -
Flags: review?(jst)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 191004 [details] [diff] [review]
Proposed patch
r+sr=jst. Looks good, but:
if (!visitorTrue) {
Wanna rename visitorTrue and visitorFalse to sVisitor... to indicate that
they're static?
Attachment #191004 -
Flags: superreview?(jst)
Attachment #191004 -
Flags: superreview+
Attachment #191004 -
Flags: review?(jst)
Attachment #191004 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 191004 [details] [diff] [review]
Proposed patch
Sure, I can rename before I land.
This fixes a shutdown leak...
Attachment #191004 -
Flags: approval1.8b4?
|
|
Assignee | |
Updated•20 years ago
|
Summary: [FIX]Leak radio visitors through shutdown → [FIXr]Leak radio visitors through shutdown
|
||
Updated•20 years ago
|
Attachment #191004 -
Flags: approval1.8b4? → approval1.8b4+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Closed: 20 years ago
Priority: -- → P3
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•