Closed Bug 302706 Opened 19 years ago Closed 19 years ago

[FIXr]Leak radio visitors through shutdown

Categories

(Core :: DOM: Core & HTML, defect, P3)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta4

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: fixed1.8, memory-leak)

Attachments

(1 file)

We never release some static pointers...
Attached patch Proposed patchSplinter Review
Attachment #191004 - Flags: superreview?(jst)
Attachment #191004 - Flags: review?(jst)
Comment on attachment 191004 [details] [diff] [review]
Proposed patch

r+sr=jst. Looks good, but:

     if (!visitorTrue) {

Wanna rename visitorTrue and visitorFalse to sVisitor... to indicate that
they're static?
Attachment #191004 - Flags: superreview?(jst)
Attachment #191004 - Flags: superreview+
Attachment #191004 - Flags: review?(jst)
Attachment #191004 - Flags: review+
Comment on attachment 191004 [details] [diff] [review]
Proposed patch

Sure, I can rename before I land.

This fixes a shutdown leak...
Attachment #191004 - Flags: approval1.8b4?
Summary: [FIX]Leak radio visitors through shutdown → [FIXr]Leak radio visitors through shutdown
Attachment #191004 - Flags: approval1.8b4? → approval1.8b4+
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Closed: 19 years ago
Priority: -- → P3
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4
Keywords: fixed1.8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: