Closed
Bug 302724
Opened 19 years ago
Closed 19 years ago
nsHostRecord and nsHostResolver are refcounted but don't log
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(2 files)
|
2.96 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
|
1.09 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This makes debugging refcount cycles involving these classes hard. Compare http://lxr.mozilla.org/seamonkey/source/netwerk/dns/src/nsHostResolver.h#54 to http://lxr.mozilla.org/seamonkey/source/layout/style/nsStyleContext.h#80 (not the NS_LOG_* calls in the latter).
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #203089 -
Flags: superreview?(darin)
Attachment #203089 -
Flags: review?(darin)
|
||
Updated•19 years ago
|
Attachment #203089 -
Flags: superreview?(darin)
Attachment #203089 -
Flags: superreview+
Attachment #203089 -
Flags: review?(darin)
Attachment #203089 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Assignee: darin → bzbarsky
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Comment 2•19 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
The leak stats get really confused when negative numbers are introduced.
Attachment #203288 -
Flags: superreview?(bzbarsky)
Attachment #203288 -
Flags: review?(bzbarsky)
(I checked that patch in to fix the leak stats on tinderbox; review still welcome.)
|
|
Assignee | |
Comment 5•19 years ago
|
||
Comment on attachment 203288 [details] [diff] [review] don't put negative numbers into the leak stats Doh. Thanks for catching this!
Attachment #203288 -
Flags: superreview?(bzbarsky)
Attachment #203288 -
Flags: superreview+
Attachment #203288 -
Flags: review?(bzbarsky)
Attachment #203288 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•