Extension manager: can't install multiple updates anymore

RESOLVED FIXED

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: Ria Klaassen (not reading all bugmail), Assigned: rstrong)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729 Firefox/1.0+

In the Extension manager, the button Find Updates brings up a list of available
updates.
When I click Install Now, nothing happens.
The behaviour seems to have changed between ID 2005072812 and 2005072822. 

Reproducible: Always

Steps to Reproduce:
1. Make a new profile and put a folder with old extensions (I'll try to upload
them as an attachment) in the profile.
2. In the EM click the button Find Updates.
3. After some seconds (or sometimes minutes) a list with availlable updates  is
presented.
4. Click Install Now.

Actual Results:  
Nothing.

Expected Results:  
Firefox should download and install the updates.
(Reporter)

Comment 1

12 years ago
Created attachment 191033 [details]
Folder extensions
works in the 13:57 build fails in the 15:23 pdt one for the 28th

checkins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-07-28+13%3A24%3A00&maxdate=2005-07-28+15%3A00%3A00&cvsroot=%2Fcvsroot
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Created attachment 191040 [details] [diff] [review]
patch

With the checkin of bug 302424 it appears that the command event is no longer
fired for the dialog buttons. This patch keeps the functionality generic as it
was previously and fixes the bug.
Assignee: nobody → rob_strong
Status: NEW → ASSIGNED
Attachment #191040 - Flags: review?(benjamin)
Flags: blocking-aviary1.5?

Comment 4

12 years ago
Comment on attachment 191040 [details] [diff] [review]
patch

I really don't like the substr(6) bit: raw numeric constants are almost always
a bad idea.

Please make a 'const kDialog = "dialog" and then use substr(kDialog.length) for
clarity.
Attachment #191040 - Flags: review?(benjamin) → review-
Created attachment 191430 [details] [diff] [review]
patch

addresses comment
Attachment #191040 - Attachment is obsolete: true
Attachment #191430 - Flags: review?(benjamin)

Updated

12 years ago
Attachment #191430 - Flags: review?(benjamin)
Attachment #191430 - Flags: review+
Attachment #191430 - Flags: approval1.8b4+
Fixed on trunk

/cvsroot/mozilla/toolkit/mozapps/extensions/content/list.js,v  <--  list.js
new revision: 1.2; previous revision: 1.1
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Flags: blocking-aviary1.5?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.