302750 - Extension manager: can't install multiple updates anymore

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ria Klaassen (not reading all bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729 Firefox/1.0+

In the Extension manager, the button Find Updates brings up a list of available
updates.
When I click Install Now, nothing happens.
The behaviour seems to have changed between ID 2005072812 and 2005072822. 

Reproducible: Always

Steps to Reproduce:
1. Make a new profile and put a folder with old extensions (I'll try to upload
them as an attachment) in the profile.
2. In the EM click the button Find Updates.
3. After some seconds (or sometimes minutes) a list with availlable updates  is
presented.
4. Click Install Now.

Actual Results:  
Nothing.

Expected Results:  
Firefox should download and install the updates.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Attachment: Folder extensions

Comment 2

[Peter van der Woude [:Peter6]]

works in the 13:57 build fails in the 15:23 pdt one for the 28th

checkins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-07-28+13%3A24%3A00&maxdate=2005-07-28+15%3A00%3A00&cvsroot=%2Fcvsroot

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

With the checkin of bug 302424 it appears that the command event is no longer
fired for the dialog buttons. This patch keeps the functionality generic as it
was previously and fixes the bug.

Comment 4

[Benjamin Smedberg]

Comment on attachment 191040 [details] [diff] [review]
patch

I really don't like the substr(6) bit: raw numeric constants are almost always
a bad idea.

Please make a 'const kDialog = "dialog" and then use substr(kDialog.length) for
clarity.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

addresses comment

Comment 6

[Robert Strong (they/them - no direct email)]

Fixed on trunk

/cvsroot/mozilla/toolkit/mozapps/extensions/content/list.js,v  <--  list.js
new revision: 1.2; previous revision: 1.1