302759 - Remote maxVersion does not override install.rdf maxVersion during an upgrade

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ben Basson]

When updating extensions, Deer Park does not check the remote maxVersion value
(addons.mozilla.org) if the local maxVersion value (install.rdf) suggests
incompatibility.

Example (with Deer Park, 1.0+):

MyExtension 0.1 with a maxVersion of 1.0 (install.rdf)
MyExtension 0.2 with a maxVersion of 1.0 (install.rdf) and alternate maxVersion
of 1.0+ (addons.mozilla.org)

When Firefox checks for extension updates, it correctly identifies MyExtension
0.2 as being available from addons.mozilla.org and downloads it. 

Upon installation, a compatibility error is given instead of overriding the
local maxVersion with the remote maxVersion. I believe this could be a
regression, but cannot be sure. I'm pretty sure that it's the desired behaviour
either way, please remove the keyword if appropriate.

-> Robert Strong who has a fix for this.

Comment 1

[Ben Basson]

Nominating to block 1.8b4 to avoid problems later.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

_applyVersionUpdates checked for the existence of local target app info in the
extensions datasource but never checked if the target app info is different
when compared to the local item as in an upgrade.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Checking in nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.139; previous revision: 1.138
done

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk... thanks for the checkin Gavin