302782 - Crash when showing list of users in a group during group deletion

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Teemu Mannermaa (:wicked)]

When in group deletion confirmation with a group that has atleast one associated
user, clicking "Show me which users" crashes with:

Software error:
Undef to trick_taint at Bugzilla/Util.pm line 62
	Bugzilla::Util::trick_taint('undef') called at
/var/www/html/qa220rc2/editusers.cgi line 135

and following appears on error log:

[Sat Jul 30 10:09:19 2005] [error] [client 194.100.2.66] [Sat Jul 30 10:09:19
2005] editusers.cgi: Undef to trick_taint at Bugzilla/Util.pm line 62, referer:
http://landfill.bugzilla.org/qa220rc2/editgroups.cgi?action=del&group=17
[Sat Jul 30 10:09:19 2005] [error] [client 194.100.2.66] [Sat Jul 30 10:09:19
2005] editusers.cgi: \tBugzilla::Util::trick_taint('undef') called at
/var/www/html/qa220rc2/editusers.cgi line 135, referer:
http://landfill.bugzilla.org/qa220rc2/editgroups.cgi?action=del&group=17

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

The problem is that the "confirm delete" template passes a "group" parameter
while editusers.cgi expects to receive a "groupid" parameter.

The patch applies on both the tip and 2.20.

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 191074 [details] [diff] [review]
patch, v1

Tested on tip and 2.20 branch.

Comment 3

[Frédéric Buclin]

tip:

Checking in template/en/default/admin/groups/delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/delete.html.tmpl,v
 <--  delete.html.tmpl
new revision: 1.5; previous revision: 1.4
done


2.20rc1:

Checking in template/en/default/admin/groups/delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/delete.html.tmpl,v
 <--  delete.html.tmpl
new revision: 1.4.4.1; previous revision: 1.4
done