302835 - The "confirm delete" page when deleting a user should distinguish between risky and no risky actions

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

When deleting a user, some deletions are safe, such as removing the user from
the CC list, removing his votes from bugs, marking pending flags where he is the
requestee as unspecifically requested, etc...

Some other deletions are unsafe and may potentially crash the Bugzilla
installation, such as bugs reported by this user, flags set by this user, etc...

The confirmation page should distinguish between these two categories, for
instance by displaying a red border for risky deletions and the actual yellow
border for safe deletions.

An easy definition of "risky" would be each deletion which produces referential
integrity breakages (a user ID with no entry in the profiles table).

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 194265 [details] [diff] [review]
patch, v1

<ul> may not contain CDATA, just <li>. If you want to put the safe/unsafe
messages into the same frame the lists are in, then you need to have the frame
on a <div>:

<div class="criticalmessages">
<p>What you're doing is not safe.</p>
<ul>
  <li>Foo</li>
  <li>Bar</li>
</ul>
</div>

This means the css file will have to be changed, too.

Good otherwise.

Comment 3

[Frédéric Buclin]

Attachment: patch, v2

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 199825 [details] [diff] [review]
patch, v2

Yup.
Regarding the messages: against the previous patch, I believe you altered
indentation only, right? I didn't check everything again.

You're right on the display_warning thing, of course.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> indentation only, right?

right!

Comment 6

[Frédéric Buclin]

tip:

Checking in skins/standard/admin.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/admin.css,v  <--  admin.css
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/users/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.6; previous revision: 1.5
done


2.20:
Checking in skins/standard/admin.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/admin.css,v  <--  admin.css
new revision: 1.1.4.1; previous revision: 1.1
done
Checking in template/en/default/admin/users/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.4.2.2; previous revision: 1.4.2.1
done