Closed
Bug 302849
Opened 19 years ago
Closed 19 years ago
Setting locale in js shell
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
VERIFIED
FIXED
People
(Reporter: igor, Assigned: igor)
Details
Attachments
(1 file)
|
611 bytes,
patch
|
shaver
:
review+
|
Details | Diff | Splinter Review |
Currently js shell does not call setlocale which prevents testing locale-sensitive behavior of functions like toLocaleString() in the shell. I suggest to call setlocale(LC_ALL, "") at the shell startup so shell behavior would be sensitive to locale-specific environment.
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 191127 [details] [diff] [review] Implementation Is it possible to apply this to the trunk?
Attachment #191127 -
Flags: review?(shaver)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 191127 [details] [diff] [review] Implementation As long as we don't need to condition that for any platforms that lack setlocale, r=shaver
Attachment #191127 -
Flags: review?(shaver) → review+
|
||
Comment 4•19 years ago
|
||
Man, I would love this in the browser to allow me to set locales for various tests.
|
|
Assignee | |
Updated•19 years ago
|
Assignee: general → igor.bukanov
|
|
Assignee | |
Comment 5•19 years ago
|
||
I committed the fix: I did not have write access at time of getting review+ and then I forgot about the patch for 4 months :(
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•