302859 - Missing "Close" button on View Saved Passwords

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050731 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050731 Firefox/1.0+

In Prefernces->Privacy->Passwords, clicking the "View Saved Passwords" button
opens a dialog box with no way to close the window except the OS-provided
window-close widget. This doesn't seem consistant with other Firefox dialog
boxes, and also seems to conflict with bug 284096, which says that there was
both a Cancel button AND a close button.

Reproducible: Always

Steps to Reproduce:
1. Edit->Preferences
2. Privacy section
3. Passwords tab
4. Click "View saved passwords"

Actual Results:  
The only way to close the dialog is with my window-manager provided "Close
window" widget.

Expected Results:  
I'd expect a "Close" button, instead of having to rely on the Windowing System
UI to provide close functionality.

Using GNOME 2.10.0 with Fedora Core 4, and CVS build of Mozilla

.mozconfig
# Options for client.mk.
mk_add_options MOZ_CO_PROJECT=browser
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@
mk_add_options MOZ_MAKE_FLAGS=-j4

# Options for 'configure' (same as command-line options).
ac_add_options --enable-default-toolkit=gtk2
ac_add_options --enable-application=browser
ac_add_options --enable-svg
ac_add_options --enable-optimize
ac_add_options --disable-debug
ac_add_options --enable-reorder
ac_add_options --enable-xft
ac_add_options --disable-tests
ac_add_options --enable-static
ac_add_options --disable-shared

Comment 1

[Ria Klaassen (not reading all bugmail)]

If you mean that the button is cut off, probably Bug 283697.

Comment 2

[Dan]

No, that isn't an issue.  While the Options dialog does have some things cut
off, I can resize to fix that.

I'm referring to the View Saved Passwords dialog, which is a sub-dialog box of
the Options dialog box. I've stretched and widened, and made taller, and thinner
the View Saved Passwords dialog box, and it responds beautifully. There just
isn't an immediately obvious way to close the dialog box

I'm trying to figure out how to take a screenshot, and then I'll need to blur
out the entries, but eventually I'll show you. :)

Comment 3

[Adam Guthrie]

Please see bug 228847 comment 1 and bug 183419 comment 34 for the reasoning
behind this. This is not a bug. This dialog is not meant to have a close buttton
because of the type of dialog it is. Same goes for the theme/extension manager,
download manager, etc.

Comment 4

[Dan]

if he says so... I disagree... but then, I'm not the one with CVS access :)

I think I'd like to test to see if it can be closed with no WM running, via key
presses or something. If it'll respond to ESC or alt-F4 or some such, then I
guess its a bit less of an issue.


For curiousity's sake, by the logic in those threads, why does the Preferences
dialog box have a Close button, as opposed to consistantly not having a close
widget?  (Not that I'd like that for preferences either; to me, it seems that
the established norm is to have any global preferences dialog give an explicit
option of cancelling out of any changes made, accepting, or applying if the
dialog is modeless. If its modeless, then maybe "Revert" and "Apply")

But I ramble. There's probably a bug with that discussion already :)

Comment 5

[[:Aleksej]]

I've tried running Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007091704 Minefield/3.0a8pre with Xephyr without any WM, and there seem to be more problems than just that.

Comment 6

[Ryan Hickman]

Closing (FIXED) due to the "Saved Passwords" dialog being both moved and changed since the submission date as well as last comment date.

Please re-open a ticket if the issue still exists in the most recent trunk release in your window manager.

KDE 4.03 - Kubuntu Hardy Alpha

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008040804 Minefield/3.0pre