Closed
Bug 302916
Opened 20 years ago
Closed 20 years ago
Trunk crash [@ nsFocusController::GetWindowFromDocument]
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
People
(Reporter: allan, Assigned: jst)
References
Details
(Keywords: crash, testcase, topcrash)
Crash Data
Attachments
(2 files)
|
2.02 KB,
application/xhtml+xml
|
Details | |
|
756 bytes,
patch
|
jst
:
review+
jst
:
superreview+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
FF trunk crashes for me in nsFocusController::GetWindowFromDocument(), as it
does not null-check doc->GetScriptGlobalObject().
|
Reporter | |
Comment 1•20 years ago
|
||
Not exactly "the simplest testcase in the world" :( Needs XForms support too.
1. view another page with a link to this testcase
2. view this testcase
3. press "insert at 3"
4. press the back-button in Firefox
-> crash
|
|
Reporter | |
Comment 2•20 years ago
|
||
Simple null-check. Might just be hiding the real problem, dunno, it's the first
time I've ventured into dom/ :)
Attachment #191182 -
Flags: superreview?(jst)
Attachment #191182 -
Flags: review?(jst)
|
||
Comment 3•20 years ago
|
||
Dupe of bug 302894?
|
|
Reporter | |
Comment 4•20 years ago
|
||
(In reply to comment #3)
> Dupe of bug 302894?
Looks like it.
|
Assignee | |
Comment 5•20 years ago
|
||
Comment on attachment 191182 [details] [diff] [review]
Patch
Yeah, this does look like the right thing to do here. r+sr=jst.
Thanks for the patch!
Attachment #191182 -
Flags: superreview?(jst)
Attachment #191182 -
Flags: superreview+
Attachment #191182 -
Flags: review?(jst)
Attachment #191182 -
Flags: review+
Attachment #191182 -
Flags: approval1.8b4?
*** Bug 302894 has been marked as a duplicate of this bug. ***
*** Bug 302880 has been marked as a duplicate of this bug. ***
|
||
Updated•20 years ago
|
Blocks: splitwindows
|
||
Updated•20 years ago
|
Attachment #191182 -
Flags: approval1.8b4? → approval1.8b4+
|
|
||
Comment 8•20 years ago
|
||
Adding topcrash+ keyword since this is a recent regression starting 7/31, we
have a testcase, and a patch ready to go. Assigning to jst since he made some
changes recently to that part of the code. Let's get this patched up.
Assignee: general → jst
Keywords: topcrash
Summary: crash @ nsFocusController::GetWindowFromDocument() → Trunk crash [@ nsFocusController::GetWindowFromDocument]
|
|
Assignee | |
Comment 9•20 years ago
|
||
Fix checked in, thanks for the patch!
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 10•20 years ago
|
||
*** Bug 302956 has been marked as a duplicate of this bug. ***
Verified FIXED using build 2005-08-02-05 on Windows XP SeaMonkey trunk.
Status: RESOLVED → VERIFIED
|
||
Updated•14 years ago
|
Crash Signature: [@ nsFocusController::GetWindowFromDocument]
|
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•