302980 - Malformed Get More Extensions URL

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ron Mutchler]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050801 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050801 Firefox/1.0+

When using the Get More Extensions link in the Extensions Manager, Deer Park is
not passing the proper string to the URL.  The URL at UMO you are kicked to is
https://addons.mozilla.org/extensions/?application=%APPID%

Reproducible: Always

Steps to Reproduce:
1. Tools -> Extension Manager
2. Click on Get More Extensions
3.

Actual Results:  
Referred to https://addons.mozilla.org/extensions/?application=%APPID%

Expected Results:  
Should have been referred to
https://addons.mozilla.org/extensions/?application=firefox

Comment 1

[O. Atsushi (Torisugari)]

The application id of firefox is
{ec8030f7-c20a-464f-9b0e-13a3a9e97384}


Then, "Expected Results:" would be
https://addons.mozilla.org/extensions/?application={ec8030f7-c20a-464f-9b0e-13a3a9e97384}

...?

Comment 2

[O. Atsushi (Torisugari)]

This is a regression of bug 301398 (cecked in on 2005-07-25)

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.js#212
> document.getElementById('getMore').setAttribute('href', gGetMoreURL);
is too early.

Comment 3

[Ron Mutchler]

I apologize for the wrong appid.  I will be more careful in the future.

Comment 4

[Aaron Leventhal]

Attachment: Set href after gGetMoreURL is really ready, and take advantage of var getMore for element

Comment 5

[Aaron Leventhal]

Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <-- 
extensions.js
new revision: 1.70; previous revision: 1.69
done