302989 - Bookmarks Manager: folder view should not be affected by sort column setting

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Will Budreau]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

Adding a bookmark with control-D and clicking on expand arrow to choose where to
put the bookmark shows me all my bookmarks hiearchically, using alphabetical
sorting.

This is disconcerting because I have organized + ordered the Bookmarks menu to
my liking and expect the same ordering in this tree view which does not allow me
to control the sort order.

It turns out that the sort order of Add Bookmarks is the same as the sort order
of the Bookmark Manager.

Reproducible: Always

Steps to Reproduce:
1. Drag and drop to reorganize bookmark menu
2. Open Bookmark Manager, sort on Name
3. Choose "Add a Bookmark" command
4. Expand bookmark tree

Actual Results:  
Bookmarks are sorted alphabetically within hierarchy

Expected Results:  
Left the bookmarks sorted the way I organized them, or else provide me with
control to choose the sorting mechanism.

Comment 1

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050801 Firefox/1.0+
ID:2005080113

It shows them in the same order they are in the bookmarks manager for me. Could
you test this on one of the latest builds?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 2

[Will Budreau]

Comment 1 is a demonstration of the issue - unless the add bookmarks dialog
includes sorting controls, it should not change its sort order based on
(display) sort order of the Bookmarks Manager.

Yes, still an issue in nightly download 1.8b4: 2005080106

Comment 3

[Adam Guthrie]

I'm not sure I understand the issue here. When I choose "Bookmark This Page"
from the context menu and expand the tree in the Add Bookmarks dialog the tree
is organized just as it is in my Bookmarks menu. Are you asking that this tree
view is separate from the Bookmarks menu?

Comment 4

[Will Budreau]

Attachment: screenshot of unexpected bookmark sort order

There are four places I see bookmarks
1) My bookmarks menu (shown under toolbar)- here the bookmarks remain in the
order I add/move them
2) The Manage Bookmarks window (not shown) which can be sorted or not, there is
"unsorted" which allows me to see the order I've enforced, or I can sort on any
of the columns that are visible

These two work as expected

3) The "Add Bookmarks" dialog (shown on right) displays a full hierarchical
tree of bookmarks, without any sorting control.
4) The Bookmarks sidebar (shown on left) displays a full hierarchical list of
bookmarks, with the ability to filter but not sort

These two will be sorted on the last sort done within the Manage Bookmark
[window] instead of the order that I put them in, and there is no indication
that the only way to change their ordering is to go to the Manage Bookmark
window.

You can see some strange sorting artifacts in the sidebar where dividing lines
are sorting together

Comment 5

[Will Budreau]

Okay, it turns out the behavior is about the folder pane in general, whether
viewed in the
- left side of bookmark manager
- sidebar
- add bookmarks window

In the bookmark manager, there's a two-pane view: the tree view (on the left)
and the sortable table on the right.

Clicking the sort column in the table should NOT also sort the tree view to the
left.

Comment 6

[Shawn Wilsher :sdwilsh]

WORKSFORME in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b3pre) Gecko/20090107 Shiretoko/3.1b3pre RTSE/1.1.0.20081207 ID:20090107020449