302992 - --enable-crypto dependencies are incomplete

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Matthias Bockelkamp]

My MinGW build with --enable-crypto failed while creating mime.dll because of
references to an unknown functions "mime_crypto_stamped_p" and
"mime_set_crypto_stamp". I cannot repeat the exact error message. This can be
fixed with two "#include"s. Patch follows. Can someone confirm this issue?

Comment 1

[Matthias Bockelkamp]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

This is current trunk build?

Comment 3

[Matthias Bockelkamp]

I did the checkout today, about 4 hours ago.

Comment 4

[Daniel Veditz [:dveditz]]

Why/how does this patch help? Both files include mimemoz2.h which already
includes mimei.h

Comment 5

[Daniel Veditz [:dveditz]]

I notice mimemoz2.h contains

 #ifdef XP_UNIX
 #undef Bool
 #endif

right before including mimei.h -- perhaps the real fix is to add mingw to that
ifdef (assuming it has unix-like headers).

Comment 6

[cls]

This sounds like the problem that occurs when the build is first made without
--enable-crypto then --enable-crypto is added.  Unfortunately, changing that
flag doesn't cause certain parts of the tree (the ones that rely upon
BUILD_SMIME, iirc) to be rebuilt.

BTW, My cross-compiled mingw build worked fine with a current tree.

Comment 7

[Matthias Bockelkamp]

This happened to me after changing .mozconfig, but also after a "make clean" and
manually deleting the obj dir.

How does this "#undef Bool" influence the following #include?

Comment 8

[Gregory Szorc [:gps]]

To think there was a time when crypto had to be enabled in configure. Anyway, --enable-crypto no longer exists, so this bug is invalid.