303041 - 1.7.11 source tarball removed libart_lgpl directory without adapting the makefiles

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Martin Pitt]

User-Agent:       Mozilla/5.0 (X11; U; Linux ppc; de-DE; rv:1.7.6) Gecko/20050405 Firefox/1.0 (Ubuntu package 1.0.2)
Build Identifier: Mozilla/5.0 (X11; U; Linux ppc; de-DE; rv:1.7.6) Gecko/20050405 Firefox/1.0 (Ubuntu package 1.0.2)

Up to 1.7.10, other-licenses/libart_lgpl/ contained libart sources, in the
1.7.11 tarball, the directory is basically empty. However, all the makefiles
still refer to it and want to build it, but of course that fails due to the
missing Makefile in other-licenses/libart_lgpl/. The build failure happens even
if I configure with --disable-svg-renderer-libart and --enable-svg-renderer-cairo.

In the unstable branch, the Makefiles should be adopted to not build
other-licenses/libart_lgpl/ any more (at least not if
--disable-svg-renderer-libart is given). However, in the 1.7.x bugfix branch the
directory contents should just be added back, since it is incredibly painful to
cope with such major changes in a security release, which is supposed to do only
minimal changes.

Thank you in advance!

Reproducible: Always

Steps to Reproduce:

Actual Results:  
make[3]: Entering directory
`/home/pitti/moz/mozilla-1.7.11/build-tree/mozilla/other-licenses/libart_lgpl'
make[3]: *** No rule to make target `export'.  Stop.
make[3]: Leaving directory
`/home/pitti/moz/mozilla-1.7.11/build-tree/mozilla/other-licenses/libart_lgpl'
make[2]: *** [tier_1] Error 2

Comment 1

[Martin Pitt]

I found a workaround for this, the package defined MOZ_INTERNAL_LIBART_LGPL=1,
which I previously changed to "... = 0". Completely removing it helps a bit, but
it's still broken. If building with --enable-svg-renderer-libart, build stops
with "no SVG rendering backend", if building with --enable-svg-renderer-cairo it
fails with

/usr/include/cairo/cairo.h:231: error: too few arguments to function 'cairo_t*
cairo_create(cairo_surface_t*)'
nsSVGCairoCanvas.cpp:118: error: at this point in file
nsSVGCairoCanvas.cpp:121: error:
'cairo_set_target_drawable_DEPRECATED_BY_cairo_xlib_surface_create' was not
declared in this scope
nsSVGCairoCanvas.cpp: In member function 'virtual nsresult
nsSVGCairoCanvas::Clear(nscolor)':
nsSVGCairoCanvas.cpp:207: error:
'cairo_set_rgb_color_REPLACED_BY_cairo_set_source_rgb' was not declared in this
scope
make[1]: *** [nsSVGCairoCanvas.o] Error 1
make[1]: Leaving directory
`/home/pitti/moz/mozilla-1.7.11/build-tree/mozilla/layout/svg/renderer/src/cairo'

since cairo recently broke the API.

That's what I mean with "please don't change big things between microreleases,
it causes nothing but trouble".

Thanks in advance,

Martin

Comment 2

[Chase Phillips]

Haven't had a chance to confirm but I think this is likely to be real.  It's not
the end of the world, we'll probably tag some extra pieces based on date and
recreate the source tarball.

coop, I can handle this, I neglected to bring you up to speed on some of the
finer details in http://www.mozilla.org/build/release-checklist.html.  If you
want to handle it, though, ping me on IRC and I'll walk you through the changes
that are necessary.

Comment 3

[Chris Cooper [:coop] (he/him)]

Chase: I can take care of this if you haven't already started the process. I'll
catch you on IRC today.

Comment 4

[Chris Cooper [:coop] (he/him)]

I've tagged the extra files listed here:
http://www.mozilla.org/build/release-checklist.html. I will create a new source
tarball shortly.

Comment 5

[Chris Cooper [:coop] (he/him)]

New source tarballs are ready and awaiting signing on stage.

Comment 6

[Chase Phillips]

(In reply to comment #5)
> New source tarballs are ready and awaiting signing on stage.

Merged, signed, pushed.