303060 - extension Html Validator broken after 12 JUL 2005 deerpark version due to ID change in viewsource.xul

Status: VERIFIED INVALID

(Toolkit :: View Source, defect)

Description

[mgueury]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050801 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050801 Firefox/1.0+

I am the author of an extension called HTML Validator.
This extension extends the viewsource of Firefox to show the list of the
HTML errors.

In the latest alpah version (post alpha 2) of Firefox (deerpark) 
my extension does not show his panel anymore in the viewsource.
This is due to a change in viewsource.xul

BEFORE (OK): <window id="main-window"
AFTER (BUG): <window id="viewSource"

Due to this, the XUL overlay does not match anymore and my extension is 
broken. This is very annoying for me since WA this will request a lot of
work. And I do not see any advantage of renaming this windows ID ?

I would be very grateful if that change could be rollback.



Reproducible: Always

Steps to Reproduce:
0. You need to use the latest nightly build of Deerpark (Deerpark A2 is too 
   old and does not show the problem)
1. Install the HTML Validator extension
   http://users.skynet.be/mgueury/mozilla/
2. Restart Firefox
3. Go to www.google.com
3. Go in the viewsource
   -> the HTML validator panels does not show up

Actual Results:  
   -> the HTML validator panels does not show up

Expected Results:  
   -> the HTML validator panels should be shown
Like show here:
http://users.skynet.be/mgueury/mozilla/screenshot.html

Comment 1

[Asaf Romano (gone)]

You'll have to update the extension per this change. We've changed it in order
to 1) Support a browser-specific-overlay in the Right Way
(viewSourceOverlay.xul) 2) Allow themes to specify a window icon to view source
windows.

-> invalid.

Comment 2

[mgueury]

Hi Asaf, 

I think you are the person who did the change :-) I saw it in LXR. 
Changing the id, even if it looks a small change, will make me duplicate 
several hundreds of lines in my XUL code.

It is really annoying for a small ID change ! And I am not even sure 
it will work. 

Else I would need to release a separate version for 1.1 and 1.0 what is
unhappilly not possible in UMO.

Thanks.

(Ps: this is just for your info. You can reclose the bug, I will try to wa it)

Comment 3

[mgueury]

I could wa the issue by duplicating all the XUL code.
I do not like this, but I have no other way to do it.

Whatever, thanks a lot for the explanation. I know why this change was needed.

Comment 4

[Bastian Grupe]

(In reply to comment #3)
> I could wa the issue by duplicating all the XUL code.
> I do not like this, but I have no other way to do it.
> 
> Whatever, thanks a lot for the explanation. I know why this change was needed.
> 

Why is it necessary to *duplicate* all the XUL code? can't you make sort of a
switch?

if(versioncheck) { var viewSourceId = "viewSource"; } else { var viewSourceId =
"main-window"; } ?