userprefs.cgi should call ThrowUserError for old_password_required

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Accounts
--
minor
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Wurblzap, Assigned: Wurblzap)

Tracking

2.20
Bugzilla 2.20
Bug Flags:
approval +
approval2.20 +

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
If you don't give the old password when changing your e-mail address, Bugzilla
displays "An internal error has occured, but Bugzilla doesn't know what
old_password_required means".

Instead of ThrowCodeError('old_password_required'), userprefs.cgi should call
ThrowUserError('old_password_required').
(Assignee)

Comment 1

13 years ago
This happens only if the user can log in by a user_verify_class other than DB.
(Assignee)

Comment 2

13 years ago
Created attachment 191319 [details] [diff] [review]
Patch
Attachment #191319 - Flags: review?
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20

Comment 3

13 years ago
Comment on attachment 191319 [details] [diff] [review]
Patch

r=LpSolit
Attachment #191319 - Flags: review? → review+

Updated

13 years ago
Flags: approval?
Flags: approval2.20?
you have time to test this on 2.20 after it's checked in before it gets
released, right?
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+

Comment 5

13 years ago
tip:

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.80; previous revision: 1.79
done


2.20rc1:

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.75.4.4; previous revision: 1.75.4.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.