Feedview: store default stylesheet URL in externalCSS preference

RESOLVED INVALID

Status

()

Firefox
RSS Discovery and Preview
--
enhancement
RESOLVED INVALID
13 years ago
7 years ago

People

(Reporter: myk, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

13 years ago
Currently we compose style from the default stylesheet and a user-supplied one,
if any.  This means users who want to create a completely new look for feeds
have to override all rules in the default stylesheet, while users who just want
to modify a subset of the look have to provide only the relevant rules.

We could instead store the default stylesheet value in the preference so we use
either the default stylesheet or a user-supplied one.  Then complete new lookers
wouldn't have to override all rules in the default, merely provide their own;
and subsetters would have to copy the default stylesheet rules into their
stylesheet.

The latter approach is better, since it involves no complex analysis of existing
rules.  The worst case is a file copy or cut and paste, whereas the worst case
for the current approach is carefully parsing the default stylesheet to
determine what every rule does and whether/how to override it, plus debugging
problems by examining the interaction of your rules and the default ones.

We should adopt the latter approach.  As a side-effect, it fixes bug 303049.

Comment 1

13 years ago
Fixing summary so it's discoverable.
Summary: store default stylesheet URL in externalCSS preference → Feedview: store default stylesheet URL in externalCSS preference
Component: General → RSS Discovery and Preview
Closing: Son of Feedview's "preview" display is going to be different enough to have brand new bugs.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → INVALID
Resetting QA Contact to default.
QA Contact: general → rss.preview
You need to log in before you can comment on or make changes to this bug.