Closed
Bug 303102
Opened 19 years ago
Closed 19 years ago
[FIXr]nsWindowWatcher::GetWindowScriptObject is unused
Categories
(Core Graveyard :: Embedding: GRE Core, defect, P2)
Core Graveyard
Embedding: GRE Core
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
2.49 KB,
patch
|
jst
:
review+
jst
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Found this while reviewing bug 296639. Right now this would get the outer JSObject, which is probably wrong anyway. But it's unused, so I saw we should just remove it.
|
Assignee | |
Updated•19 years ago
|
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Summary: nsWindowWatcher::GetWindowScriptObject is unused → [FIX]nsWindowWatcher::GetWindowScriptObject is unused
Target Milestone: --- → mozilla1.8beta4
|
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #191346 -
Flags: superreview?(jst)
Attachment #191346 -
Flags: review?(jst)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 191346 [details] [diff] [review] Patch r+sr=jst
Attachment #191346 -
Flags: superreview?(jst)
Attachment #191346 -
Flags: superreview+
Attachment #191346 -
Flags: review?(jst)
Attachment #191346 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 191346 [details] [diff] [review] Patch Simple code removal
Attachment #191346 -
Flags: approval1.8b4?
|
|
Assignee | |
Updated•19 years ago
|
Summary: [FIX]nsWindowWatcher::GetWindowScriptObject is unused → [FIXr]nsWindowWatcher::GetWindowScriptObject is unused
|
||
Updated•19 years ago
|
Attachment #191346 -
Flags: approval1.8b4? → approval1.8b4+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•