303106 - Provide a way to open feedview for an existing live bookmark

Status: RESOLVED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Stebs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050802 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050802 Firefox/1.0+

Since we now have the new Feedview functionality, it makes no sense that
left-click on a Live Bookmark itself (not on one of its items) opens nothing.



Reproducible: Always

Steps to Reproduce:
Click on the orange icon of an Live Bookmark
Actual Results:  
Nothing

Expected Results:  
Open the Feedview of that Feed

We might go further and add functionality that when you try to Bookmark an
Feedview, it is automatically detected that it can be a Live Bookmark.
But perhaps with an Question if the new Bookmark should act as Live Bookmark
(also with the ability in Preferences of an Feed Bookmark to switch Live
Bookmark functionality on and off) - Maybe also a Preference in Options to
generally disable Live Bookmarks functionality (so the Question does not need to
come up)

Comment 1

[Dave Townsend [:mossop]]

Not sure what you are talking about clicking on here. Clicking the livemark icon
in the status bar pops a menu to add the feed. Clicking it in the bookmarks
opens up the list of items.

It might be an idea to have "View feed" in the menu of the status icon, but not
sure how that would work with multiple feeds to a page.

Comment 2

[Stebs]

(In reply to comment #1)
> Clicking it in the bookmarks opens up the list of items.
Actually hovering over an Live Bookmark in bookmarks shows the list of items,
clicking on it does nothing, but middle-clicking on it opens every item... 

Comment 3

[Stebs]

Please ignore the last part of my Bugreport (We might go further...come up)
This does not really belong to this Bug and mostly is discussed in Bug #303105

This Bug is simply about opening the feed from a "live bookmark folder" in
bookmarks by left-clicking on the "live bookmarks folder".
Left-clicking this Folder has no function atm... 

Comment 4

[Dave Townsend [:mossop]]

Clicking the folder does open the menu, just quicker than waiting for the
standard popup delay, and this is certainly the case on the bookmarks toolbar.
Also clicking is usually analogous to pressing enter and that makes the menu
appear too. I expect that doing something different on the click would be
incorrect as far as the HIGs go.

Comment 5

[Stebs]

Sorry, mea culpa. Didnt see that left-click is already used because I have set
ui.submenuDelay", 0. So even Safe-Mode didnt help there...
Changing Summary to "Provide a way to open live bookmarks in feedview" 

Comment 6

[Adam Guthrie]

I'm not sure if I understand the issue. We still offer live bookmarks
functionality with the live bookmarks icon in the status bar. Feedview
(currently) only is implemented when viewing a feed in and of itself.

When you are viewing a feed with feedview, clicking the live bookmark icon opens
a pop up saying "subscribe to "current feed". It sounds like your issue is
extension related...

Comment 7

[Dave Townsend [:mossop]]

But what if I want to view the feed in feedview? The livemark only gives the
titles but to see the summary I have to use feedview. This bug is about
providing a way to open the livemark you have saved in feed view for more detail
on each item.

Comment 8

[Stebs]

What about adding an item "Open Feedview" (or whatever we want this called) to
the top or the bottom of the items in the Live Bookmarks Folder? We already have
"Open in Tabs" there on the bottom...
Seems to be the only way to add this (needed IMHO) Functionality I can think of.
Beeing on top of the list would stress the fact that the Feedview is a sort of
Summary of all items below (and make it faster to reach). But I fear it could be
somewhat ugly and inconsistent having an "fixed" item on top AND on the bottom,
so maybe the bottom would be the best place?
Mossop, could you change this to NEW?

Comment 9

[Stebs]

(In reply to comment #6)
> I'm not sure if I understand the issue.
This is not about opening a live bookmark from an feedview, but the opposite:
Having a way to open an Feedview with your existent live bookmark.
Maybe change Summary again to be clear? -Any suggestions?

Comment 10

[Thomas Yde]

How about double clicking the Live Bookmark folder to open it in Feedview?

Comment 11

[Michael Lefevre]

Having two independent UIs for viewing feeds which don't integrate with each 
other does seem rather clunky and potentially confusing. If this is going to 
be fixed with a UI change then it probably needs to happen before the beta if 
it's going to happen at all.

Comment 12

[:Gijs (he/him)]

Attachment: Patch v1

Patch to add:
* Support to open the feed by double-clicking on the feed's livebookmark item.
This doesn't work on the personal bookmarks toolbar (for fairly obvious
reasons)
* Support to open the feed by using a (more discoverable) menu item just below
'Open in Tabs', called 'Open Feed Summary'.

That's all, really. This is my first patch for anything in mozilla/browser/* .
Unfortunately, I will not have access to any machines fit for development /
testing for an undetermined period of time - I'm moving house and I don't know
when my internet connection will be in order at my new address.

Please consider this patch, and if there's anything wrong with it (and we still
want it in), please update it yourselves, because it doesn't look like I will
be able to do so before we branch. Sorry! :(

Comment 13

[Phil Ringnalda (:philor)]

*** Bug 304221 has been marked as a duplicate of this bug. ***

Comment 14

[:Gijs (he/him)]

After discussion on IRC, the following was agreed:

* This patch/feature will not go into 1.5, only into something like 1.5.1 - if that.

* We're getting rid of the double click handler in favor of just the extra
submenu-item. New patch coming up.

CC-ing Mike Beltzner on request.

It also appears my new ISP is faster than expected with granting me net access.
Since I will be able to work on this for some time after all, I'm taking this bug.

Comment 15

[Stebs]

(In reply to comment #14)
> * We're getting rid of the double click handler in favor of just the extra
> submenu-item. New patch coming up.

Having thought about this for a while, I think double click seems to be a good
idea after all.
Take a look at the Start Menu from Windows XP (in "classical" mode). Isn't it
dealing basically with the same things that we are talking about here?:
It has single items, folders with items and subfolders etc.
One click on an item opens (starts) it, one click on an Folder opens it (faster
than hovering above it), double click on an Sub-Folder of an Folder (this
limitation to Sub-folder is strange IMHO) opens the Folder in an extra
Folder-View (so this could be our Feedview).
BTW, this is what the common User is already used too, Items AND Folders can be
drag'n'dropped but not in Firefox (see also Bug #235244 )

(In reply to comment #12)
> * Support to open the feed by double-clicking on the feed's livebookmark item.
> This doesn't work on the personal bookmarks toolbar (for fairly obvious
> reasons)
Is the reason really that obvious? An Live_bookmark on the personal bookmarks
toolbar is opened by 1 click and closed by 1 click, a double click is something
completely different and there are special Windows Settings for the User to help
him differentiate this. -Or did I simply miss another obvious reason ;)

Comment 16

[Stebs]

Correction:
Limitation to sub-folder (for opening that whole folder with double-click) is
only for "classical Start-Menu", in default WindowsXP Start-menu, every Folder
can be opened by double-click. Why not use the same UI behavior for Firefox (at
least under Windows)?

Comment 17

[Dave Townsend [:mossop]]

The submenu item is far more discoverable for the user.

Comment 18

[Stebs]

(In reply to comment #17)
> The submenu item is far more discoverable for the user.
I agree that this submenu item is useful -and if that's the only way to open
feedview we get for 1.5, so be it, it's already a big improvement anyway :)

But dont forget that the other submenu item "Open in Tabs" functionality can be
achieved by a middle-click on an Feed-view folder too. So this double-click
functionality (in addition to submenu item) would only be consistent behavior
IMHO... 

Comment 19

[Stebs]

Sorry for more spam, but correct Bug about general inconsistent Bookmark/Folder
drag'n'drop is: Bug# 249505 and not the one I previously mentioned.
(Hoping to prevent Spam in wrong bug -since there is not edit possibility here)

Comment 20

[Phil Ringnalda (:philor)]

*** Bug 339408 has been marked as a duplicate of this bug. ***

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

(--> RSS Discovery and Preview)

Feedview is dead, long live Feed Preview. The goal of its function will not be to provide a single place to read the entire set of feed entries, but rather to let users decide how they want to subscribe to that feed (either as live bookmark, or by using an external/online RSS reader).

The only reason to open the Feed Preview for an existing Live Bookmark would be to change the subscription mechanism. That feels like a separate bug to me, so unless Ben objects, I'd mark this one WONTFIX.

Comment 22

[Stebs]

(In reply to comment #21)
> Feedview is dead, long live Feed Preview. The goal of its function will not be
> to provide a single place to read the entire set of feed entries...

What about those Users that will indeed only use Feed Preview as their only Feed Viewer? (The new Feed Preview is not that bad at all, not everyone wants to use an online Service -always registration needed, or external Viewer).

Just found the LiveClick Extension that does what I had in mind and think is missing in Fx 2.0. Have a look:
http://liveclick.mozdev.org/  

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Those people should bookmark the feed, not LiveBookmark the feed. Or they can make sure that "Always ask me what to do" is checked in the Feed Reading properties (see bug 340677) and then clicking the RSS icon in the URL bar will always show them the feed preview. 

Comment 24

[crf]

The bug is for a way to show, from the bookmarks menu, the feed preview view, for a live bookmark, via a right-click option, or by clicking the feed icon next to the live bookmark in the bookmarks menu (or other methods).

Some comments in this bug imply that it is only rational for people to do it one way (one regular bookmark to feed, which would open feed preview when clicked), or the other (live bookmark), but irrational for people to want one live bookmark to have the ability to do both.  If you now want both, you then you now need to bookmark it twice, once as a live bookmark, a second time as a normal bookmark. That's only a good solution if you don't really care about this feature request. (Ok, there is an extension which does the job in one way.)

I'd rather there be an emphasis on discussing potential changes which don't degrade the user experience, rather than forcing users to accept an interface which some will feel is designed to control their behaviour (use it the way WE want, not the way YOU want) by artificially limiting the usefulness of feed preview as a feed viewer.

Comment 25

[Tanner M. Young [:tmyoung]]

Resetting QA Contact to default.