303172 - smime: NSSCMSKEKIdentifierTemplate template does not match the struct NSSCMSKEKIdentifierStr

Status: NEW

(NSS :: Libraries, defect, P2)

Description

[Alexei Volkov]

One more case of template missmatch in smime library that is similar to
bug https://bugzilla.mozilla.org/show_bug.cgi?id=303159 . 

nss/lib/smime/cmst.h:394 :

struct NSSCMSKEKIdentifierStr {
    SECItem			keyIdentifier;
    SECItem *			date;			/* optional */
    SECItem *			other;			/* optional */
};
typedef struct NSSCMSKEKIdentifierStr NSSCMSKEKIdentifier;

nss/lib/smime/cmsasn1.c:391:
 
static const SEC_ASN1Template NSSCMSKEKIdentifierTemplate[] = {
    { SEC_ASN1_SEQUENCE,
	  0, NULL, sizeof(NSSCMSKEKIdentifier) },
    { SEC_ASN1_OCTET_STRING,
	  offsetof(NSSCMSKEKIdentifier,keyIdentifier) },
    { SEC_ASN1_OPTIONAL | SEC_ASN1_OCTET_STRING,
	  offsetof(NSSCMSKEKIdentifier,date) },
    { SEC_ASN1_OPTIONAL | SEC_ASN1_OCTET_STRING,
	  offsetof(NSSCMSKEKIdentifier,other) },
    { 0 }
};

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Adding Bob to ASN.1 encoder/decoder related bugs

Comment 2

[Alexei Volkov]

Targeting to 3.12. Better to introduce binary incompatibility in new release, not in 3.11.x.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, and this bug has priority 'P2'.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Marco Castelluccio [:marco]]

We have modified the bot to only consider P1 as high priority, so I'm cancelling the needinfo here.