Closed
Bug 303185
Opened 19 years ago
Closed 19 years ago
xpcom/glue/nsVersionComparator.cpp: const char * mismatch in VS2005
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: mmoy, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
655 bytes,
patch
|
darin.moz
:
review+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2 x64; en-US; rv:1.8b3) Gecko/20050801 mmoy CE Deer Park Alpha 2 K8M/64-X07 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2 x64; en-US; rv:1.8b3) Gecko/20050801 mmoy CE Deer Park Alpha 2 K8M/64-X07 MSVC 2005 (Whidbey) complains about char *numstart = strpbrk(result.strB, "0123456789+-"); with the usual cannot convert from 'const char *' to 'char *' This is on a Firefox trunk build with current source. Reproducible: Always
|
Reporter | |
Updated•19 years ago
|
Summary: xpcom/glue/nsVersionComparator.cpp: const char * mismatch → xpcom/glue/nsVersionComparator.cpp: const char * mismatch in VS2005
|
||
Updated•19 years ago
|
Assignee: nobody → dougt
Blocks: 300731
Component: General → XPCOM
Product: Firefox → Core
QA Contact: general → xpcom
Version: unspecified → Trunk
|
||
Comment 2•19 years ago
|
||
Comment on attachment 191438 [details] [diff] [review] nsVersionComparator.cpp This looks good to me. r=darin
Attachment #191438 -
Flags: review+
|
|
||
Comment 3•19 years ago
|
||
-> bsmedberg
Assignee: dougt → benjamin
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Updated•19 years ago
|
Attachment #191438 -
Flags: approval1.8b4+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk for 1.8b4
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•