303254 - Invalid access key for "Save to disk" in unknownContentType.xul

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[dynamis (Tomoya ASAI)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7.11) Gecko/20050728
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7.11) Gecko/20050728

When we download unknown content, dialog will be opened to select action.
But the dialog will have invalid accesskey since unknownContentType.xul set label
as a accesskey by accident.

We must fix next line.

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/downloads/content/unknownContentType.xul#103
-         <radio id="save" label="&save.label;" accesskey="&save.label;"/>
+         <radio id="save" label="&save.label;" accesskey="&save.accesskey;"/>

Reproducible: Always

Comment 1

[Adam Guthrie]

Attachment: diff of the reporter's patch

Comment 2

[dynamis (Tomoya ASAI)]

This will not require l10n updates.
&save.accesskey; is already defined here:
http://lxr.mozilla.org/mozilla/source/toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd#49

FYI: Bug 303997 is similar to this (not depends, blocks nor duplicates).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Checking in unknownContentType.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/unknownContentType.xul,v  <--
  unknownContentType.xul
new revision: 1.11; previous revision: 1.10
done