303270 - Theme's chrome.manifest are not always created when upgrading

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Split off from the original patch in bug 302750... patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Actually split off from the original patch in bug 302581.

This combines upgradeExtensionChrome and _upgradeThemeChrome... I could clean
up the code but don't have the time to do so atm. This also addresses what I
believe caused the upgradeExtensionChrome failure in bug 302527 - I was able to
reproduce this error and fixed the case I found. This also fixes a failure when
clicking finish on the update wizard during an upgrade due to a constant name
change (e.g. PREF_EXTENSIONS_UPDATE_ENABLED was changed to
PREF_UPDATE_EXTENSIONS_ENABLED).

Comment 2

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.140; previous revision: 1.139
done
Checking in mozilla/toolkit/mozapps/extensions/content/update.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/update.js,v  <--  update.js
new revision: 1.16; previous revision: 1.15