[BUGZILLA] When directly addressed, mozbot should report information about bugs regardless of whether its within backOffTime

VERIFIED FIXED in 2.6

Status

Webtools
Mozbot
VERIFIED FIXED
13 years ago
8 years ago

People

(Reporter: cso, Assigned: cso)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
Mozbot used to always respond to "bug xyz" when directly addressed, but bug
293181 changed that.

Forthcoming patch to put the facility back...
(Assignee)

Comment 1

13 years ago
Created attachment 191508 [details] [diff] [review]
Patch v1
Attachment #191508 - Flags: review?(mkanat)
(Assignee)

Updated

13 years ago
Summary: When directly addressed, mozbot should report information about bugs regardless of whether its within backOffTime → [BUGZILLA] When directly addressed, mozbot should report information about bugs regardless of whether its within backOffTime

Comment 2

13 years ago
Comment on attachment 191508 [details] [diff] [review]
Patch v1

>@@ -168,9 +168,9 @@
>         my $bug = $1;
>         # Single bugs use xml.cgi, because then we get error messages
>         if ($bug =~ m/^\d+$/) {
>-            $self->FetchBug($event, $bug, 'bug', 0, 0);
>+            $self->FetchBug($event, $bug, 'bug', 0, 0, 1);
>         } else {
>-            $self->FetchBug($event, $bug, 'bugs', 0, 0);
>+            $self->FetchBug($event, $bug, 'bugs', 0, 0, 1);
>         }
>         $self->{'bugsHistory'}->{$target}->{$bug} = $event->{'time'} if $bug =~ m/^[0-9]+$/os;
>     } elsif ($message =~ m/^\s*bug-?total\s+(.+?)\s*$/osi) {

  This looks like he'll $sayAlways every time somebody mentions "bug 123456",
even if the bot isn't being directly adressed...?
Attachment #191508 - Flags: review?(mkanat) → review-
(Assignee)

Comment 3

13 years ago
Comment on attachment 191508 [details] [diff] [review]
Patch v1

It lives in sub Told, which, according to BotModules/devel.txt is called for
messages prefixed by the bot's nickname.
Attachment #191508 - Flags: review- → review?(mkanat)

Comment 4

12 years ago
Comment on attachment 191508 [details] [diff] [review]
Patch v1

OK, if you say it works, I believe you. It looks all right.

However, I'd really like those last three FetchBug params to become a single hash (named parameters) instead of sequential parameters. Could you perhaps do that?
Attachment #191508 - Flags: review?(mkanat) → review+
(Assignee)

Comment 5

12 years ago
Created attachment 202874 [details] [diff] [review]
Patch v2

Hashrefs.... think I got all the callers.
Attachment #202874 - Flags: review?(mkanat)

Comment 6

12 years ago
Comment on attachment 202874 [details] [diff] [review]
Patch v2

Yeah, that looks much better. :-)

r=mkanat by inspection
Attachment #202874 - Flags: review?(mkanat) → review+
(Assignee)

Comment 7

12 years ago
Fix checked in...

Checking in BotModules/Bugzilla.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Bugzilla.bm,v  <--  Bugzilla.bm
new revision: 2.18; previous revision: 2.17
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
QA Contact: kerz → mozbot

Updated

9 years ago
Target Milestone: --- → 2.6
Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.