303284 - [BUGZILLA] When directly addressed, mozbot should report information about bugs regardless of whether its within backOffTime

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, defect)

Description

[Colin Ogilvie [:cso]]

Mozbot used to always respond to "bug xyz" when directly addressed, but bug
293181 changed that.

Forthcoming patch to put the facility back...

Comment 1

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Comment 2

[Max Kanat-Alexander]

Comment on attachment 191508 [details] [diff] [review]
Patch v1

>@@ -168,9 +168,9 @@
>         my $bug = $1;
>         # Single bugs use xml.cgi, because then we get error messages
>         if ($bug =~ m/^\d+$/) {
>-            $self->FetchBug($event, $bug, 'bug', 0, 0);
>+            $self->FetchBug($event, $bug, 'bug', 0, 0, 1);
>         } else {
>-            $self->FetchBug($event, $bug, 'bugs', 0, 0);
>+            $self->FetchBug($event, $bug, 'bugs', 0, 0, 1);
>         }
>         $self->{'bugsHistory'}->{$target}->{$bug} = $event->{'time'} if $bug =~ m/^[0-9]+$/os;
>     } elsif ($message =~ m/^\s*bug-?total\s+(.+?)\s*$/osi) {

  This looks like he'll $sayAlways every time somebody mentions "bug 123456",
even if the bot isn't being directly adressed...?

Comment 3

[Colin Ogilvie [:cso]]

Comment on attachment 191508 [details] [diff] [review]
Patch v1

It lives in sub Told, which, according to BotModules/devel.txt is called for
messages prefixed by the bot's nickname.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 191508 [details] [diff] [review]
Patch v1

OK, if you say it works, I believe you. It looks all right.

However, I'd really like those last three FetchBug params to become a single hash (named parameters) instead of sequential parameters. Could you perhaps do that?

Comment 5

[Colin Ogilvie [:cso]]

Attachment: Patch v2

Hashrefs.... think I got all the callers.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 202874 [details] [diff] [review]
Patch v2

Yeah, that looks much better. :-)

r=mkanat by inspection

Comment 7

[Colin Ogilvie [:cso]]

Fix checked in...

Checking in BotModules/Bugzilla.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Bugzilla.bm,v  <--  Bugzilla.bm
new revision: 2.18; previous revision: 2.17
done

Comment 8

[Tanner M. Young [:tmyoung]]

Verified Fixed.