303301 - LDAP only works for attributes that are specified in lower case

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[Mark Banner (:standard8)]

Looks like this is spill out from bug 119291 (LDAP attributes should be
customizable) and bug 116692

When we use the default attributes for LDAP, only some of the parameters work
when displaying the address book cards, things like homePhone, nsAIMid and
others don't.

The ones that do not work, do if you override them with lower case versions of
their names.

Steps to reproduce:
1) Search for an ldap card with all properties specified.
2) Display card.
3) Only some properties (name, email and others) are displayed.
4) Change attributes in prefs to lower case versions
5) Restart, redo search and changed attributes are displayed correctly alongside
the others.

Possible patch coming up.

Comment 1

[Mark Banner (:standard8)]

Attachment: Possible Patch (checked in)

This patch fixes the problem by setting the attribute to lower case before we
process it. I'm not sure if it is the best place to do the lower case
conversion, but I'm hoping Dan can advise on that.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 191525 [details] [diff] [review]
Possible Patch (checked in)

r+sr=dmose

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Hope you're ok with me re-assigning to you, since you've already done the work.  :-)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 191525 [details] [diff] [review]
Possible Patch (checked in)

I just checked this in:

/cvsroot/mozilla/mailnews/addrbook/src/nsAbLDAPAttributeMap.js,v  <-- 
nsAbLDAPAttributeMap.js
new revision: 1.2; previous revision: 1.1