Closed Bug 303378 Opened 19 years ago Closed 19 years ago

Unable to use XUL overlays to modify top-level PrefWindowV dialogs

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: kakadu+bugzilla, Unassigned)

References

(
URL
)

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050803 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050803 Firefox/1.0+

My extension, TBP 1.2.7.1, uses an XUL overlay referenced via chrome.manifest to
modify the attributes of one of the <prefpane/>s inside <prefwindow
id="BrowserPreferences"/>, located at
chrome://browser/content/preferences/preferences.xul.

In the 20050722 build (and earlier), this worked. In the 20050725 build (up to
the 20050803 build), this no longer works. Bonsai shows nothing obvious that
would explain this breakage, and TBP itself has not changed since then.

Reproducible: Always

Steps to Reproduce:
1. Install a trunk nightly build with PrefWindow V.
2. Download and install TBP 1.2.7.1 (you can find a copy in the URL field).
3. Open the Firefox Preferences dialog.

Actual Results:  
The Tabs prefpane, containing the integrated tab control UI, is available.

Expected Results:  
The Tabs prefpane should have been replaced with the Tabbed Browsing prefpane,
containing additional tab controls provided by TBP.

Bug 283949 may be related to this in some way.
I see this: http://img291.imageshack.us/img291/1622/prefwindow9tw.jpg
Tried it only in my default profile.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050804
Firefox/1.0+ ID:2005080403
(In reply to comment #1)
> I see this: http://img291.imageshack.us/img291/1622/prefwindow9tw.jpg
> Tried it only in my default profile.
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050804
> Firefox/1.0+ ID:2005080403

What happens when you uninstall and reinstall TBP?
Seems to work for me. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050803 Firefox/1.0+ ID:2005080306

The new one doesnt work, but then that one doesnt overlay the correct
preferences dialog.

(In reply to comment #4)
> Could folks who report WFM please try the following XPI?
> 
> http://216.55.161.203/theonekea/tabprefs/tabprefs_1.2.8.xpi

I see this: http://img350.imageshack.us/img350/7402/prefwindow27ei.jpg
(In reply to comment #6)
> (In reply to comment #4)
> > Could folks who report WFM please try the following XPI?
> > 
> > http://216.55.161.203/theonekea/tabprefs/tabprefs_1.2.8.xpi
> 
> I see this: http://img350.imageshack.us/img350/7402/prefwindow27ei.jpg

Ah!

Is this on a Linux build?

(In reply to comment #5)
> The new one doesnt work, but then that one doesnt overlay the correct
> preferences dialog.
> 

It doesn't?
>  <RDF:Seq about="chrome://browser/content/pref/pref.xul">
>    <RDF:li>chrome://tabprefs/content/tabprefs.xul</RDF:li>
>  </RDF:Seq>
>  <RDF:Seq about="chrome://browser/content/pref/pref-advanced.xul">
>    <RDF:li>chrome://tabprefs/content/tabprefs.xul</RDF:li>
>  </RDF:Seq>

Should be overlaying chrome://browser/content/preferences/preferences.xul and
chrome://browser/content/preferences/advanced.xul right?

Maybe because the 1.2.8 is missing the chrome.manifest so is falling back to the
contents.rdf which is correct for fx 1.0.x

(In reply to comment #8)
> Maybe because the 1.2.8 is missing the chrome.manifest so is falling back to the
> contents.rdf which is correct for fx 1.0.x

s/Maybe/This is

RESOLVED WORKSFORME. Thanks anyway folks.
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.