Closed Bug 303427 Opened 19 years ago Closed 19 years ago

Assert message inserts bogus newline in XPConnect is being called on a scope without a 'Components' property!\

Categories

(Core :: XPConnect, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

()

Details

(Keywords: fixed1.8)

Attachments

(1 file)

When trying to process debug log files, it is helpful for the line containing
the ASSERTION to actually contain meaningful text. I am attempting to use this
to make sure that all assertions have bugs on file.
Attached patch trivial patchSplinter Review
Attachment #191600 - Flags: superreview?(shaver)
Attachment #191600 - Flags: review?(jst)
Attachment #191600 - Flags: approval1.8b4?
Attachment #191600 - Flags: approval1.8b4? → approval1.8b4+
Comment on attachment 191600 [details] [diff] [review]
trivial patch

r+sr=jst
Attachment #191600 - Flags: superreview?(shaver)
Attachment #191600 - Flags: superreview+
Attachment #191600 - Flags: review?(jst)
Attachment #191600 - Flags: review+
bob, time is short, so it would be good if you could get this in ASAP.
checked in to 1.8 branch:
Checking in xpcwrappednativescope.cpp;
/cvsroot/mozilla/js/src/xpconnect/src/xpcwrappednativescope.cpp,v  <-- 
xpcwrappednativescope.cpp
new revision: 1.22.4.1; previous revision: 1.22

checked into trunk
Checking in xpcwrappednativescope.cpp;
/cvsroot/mozilla/js/src/xpconnect/src/xpcwrappednativescope.cpp,v  <-- 
xpcwrappednativescope.cpp
new revision: 1.23; previous revision: 1.22
Assignee: dbradley → bob
Keywords: fixed1.8
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: