Closed Bug 303429 Opened 19 years ago Closed 19 years ago

Add build option to disable xpcom obsolete|compat

Categories

(Core :: XPCOM, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(2 files, 1 obsolete file)

 
Attached patch Patch v.1 (obsolete) — Splinter Review
This takes care of xpcom and the libpref.  xpinstall may still require some
tweaking, but this is a start and it is good enough for Minimo.
Attachment #191607 - Flags: review?(benjamin)
Comment on attachment 191607 [details] [diff] [review]
Patch v.1

tier_2_dirs += xpcom/obsolete modules/libreg

should be reversed.
Comment on attachment 191607 [details] [diff] [review]
Patch v.1

We really need to start early-failing if incompatible sets of options are
chosen: You should put a check in so that if somebody --disable-xpcom-obsolete
but doesn't --disable-xpinstall and --enable-single-profile that we fail at
configure, instead of finding out much later in the build.
Attachment #191607 - Flags: review?(benjamin) → review-
there are other options that we do not do this test for.  Consider crypto.  I
challenge you to build ff without crypto. 
I know, and I intend to add appropriate checks at some point. But you're adding
a new config option, so you get to add the checks just for that option ;-)
Attached patch patch v.2Splinter Review
Attachment #191607 - Attachment is obsolete: true
Attachment #191707 - Flags: review?
Attachment #191707 - Flags: review?
Attachment #191707 - Flags: review+
Attachment #191707 - Flags: approval1.8b4+
Comment on attachment 191707 [details] [diff] [review]
patch v.2

Sorry, I didn't review carefully: I think you want

if test -n "$MOZ_XPINSTALL"

to be

if test -n "$MOZ_XPINSTALL" && test -n "$MOZ_NO_XPCOM_OBSOLETE"
Attachment #191707 - Flags: review-
Attachment #191707 - Flags: review+
Attachment #191707 - Flags: approval1.8b4-
Attachment #191707 - Flags: approval1.8b4+
this replaces the configure.in diff from patch 2.
Comment on attachment 191709 [details] [diff] [review]
just the configure.in diff.

better ;-) at least the tboxen are much less likely to go red
Attachment #191709 - Flags: review+
Attachment #191709 - Flags: approval1.8b4+
Checking in Makefile.in;
/cvsroot/mozilla/Makefile.in,v  <--  Makefile.in
new revision: 1.298; previous revision: 1.297
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1502; previous revision: 1.1501
done
Checking in config/autoconf.mk.in;
/cvsroot/mozilla/config/autoconf.mk.in,v  <--  autoconf.mk.in
new revision: 3.363; previous revision: 3.362
done
Checking in modules/libpref/src/nsPref.cpp;
/cvsroot/mozilla/modules/libpref/src/nsPref.cpp,v  <--  nsPref.cpp
new revision: 3.175; previous revision: 3.174
done
Checking in modules/libpref/src/nsPrefBranch.cpp;
/cvsroot/mozilla/modules/libpref/src/nsPrefBranch.cpp,v  <--  nsPrefBranch.cpp
new revision: 1.65; previous revision: 1.64
done

Thanks!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: