303450 - MailBiffNotificationWindow responding to WM_ATLGETHOST (0xc1a7) with 0x01.

Status: RESOLVED INCOMPLETE

(Thunderbird :: General, defect)

Description

[Rick Gordon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

An application I'm debugging has some code in it which uses the ATL QueryHost
function. I started getting crashes upon migration to a new machine, and today
tracked it down to a window named "MailBiffNotificationWindow" responding to a
Window Message sent to it by the ATL AfxQueryHost function. That code is sending
a registered WMsg to it (WM_ATLGETHOST, Spy++ says its 0xc1a7) and it responds
with 0x01. It should respond with a valid object address or NULL. I suspect that
there is a message conflict. Since I didn't notice this on my older machine, it
may be sensitive to the latest build of Firefox.

Reproducible: Always

Steps to Reproduce:
1. I don't have a stand alone test case to reproduce this problem, its currently
only evident in a application under development.
2.
3.

Actual Results:  
My application crashes (inside ATL) because it (ATL) expects the return value
for this message to be NULL or an actual object address.

Expected Results:  
Returned NULL.

I think I covered it above.

Comment 1

[Rick Gordon]

Investigating this problem further - it appears to me that the WindowProc
associated with the Window is in error.
if you look in nsMessengerWinIntegration.cpp, the window's proc is named
MessageWindowProc. 
That function returns TRUE instead of the more typical window proc which
should return 0 if the message isn't handled.
(Usually windowproc's return the result from DefWindowProc but I figure this
isn't really a normal window...)

 

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Reporter, does the issue still occur in the latest supported 2.0.0.x / Shredder trunk nightlies?

(1.5.0.x is now end-of-life and the latest supported 2.0.0.x is 2.0.0.16)

Comment 3

[Joshua Cranmer [:jcranmer]]

RESO INCO per lack of response to the last question(s). If you feel this change was made in error, please respond to this bug with your reasons why.