30348 - Request for a nicer message when product unknown in enter_bug.cgi.

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

Hmm, there isn't an "extremely trivial" severity ...

I often type the above URL manually to save time, but sometimes mistype.  It
used to give a enter_bug screen with no data on it (eg no components), but now
it gives an error.

Either way it would be nice to get an error saying that you mistyped it.  Even
better if you get shown a list of close (fuzzy search?) matches.

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Chris Yeh]

the only way to figure out that you've mistyped a url is to try and fetch data 
from it. this strikes me as slow.

Comment 3

[Jesse Ruderman]

*** Bug 45206 has been marked as a duplicate of this bug. ***

Comment 4

[Stephan Niemz]

moving to real milestones...

Comment 5

[Matthew Tuck [:CodeMachine]]

Sorry Chris, I don't understand.  It's a lot faster to type in a URL than to
find a bookmark and navigate through two pages.

Comment 6

[GavinS]

Attachment: Patch to check product, and list products if invalid

Comment 7

[Dave Miller [:justdave]]

can you re-up the patch with diff -u instead of diff -c?  They're easier to 
review that way.

Comment 8

[GavinS]

Attachment: A more useful diff -u patch of the same thing

Comment 9

[Matthew Tuck [:CodeMachine]]

Possibly a dupe of bug #100100, also with a patch.

Comment 10

[Gervase Markham [:gerv]]

Gavin: your current patch has you printing <h2> before Content-Type:, which is
not a good thing. Is this patch still relevant, and are you looking to get it
checked in?

Gerv

Comment 11

[GavinS]

Gerv: 

I don't think this does print <h2> before the Content-Type:. If you still think
so, then I'll be happy to fix it, if you can show me where. 

This patch has been working fine here for a while (but then it's not as if it
ever gets tested much!)

And yes, I think either this, or the pretty similar patch on bug#100100 should
be checked in at some stage, as they both fix an unsightly 'Software Error' page.

(p.s. Thanks for all your work on the new link bar)

Comment 12

[Gervase Markham [:gerv]]

You'll need to look at this again when the templatisation gets checked in,
because that file has been spanked hard.

Gerv

Comment 13

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 14

[Bradley Baetz (:bbaetz)]

This got fixed with templatisation. I now get:

Error
 
'foobar' is not a valid product.

Please press Back and try again.