303485 - update manager no longer connects to update server

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Gary Elshaw]

Today's build breaks the updates manager. Here's a break down of the various
phases when trying to update, it should be noted that there is no network
traffic throughout this entire process. 

No network activity and the continue button is active for the initial screen. 

Next screen says an update is available and the usual certificate warning is not
there. 'More details' button when clicked transforms into blue active url which
pops up a new blank window. 

Clicking continue for the next stage of installation says downloading update,
however there is still no network activity and the continue button is active.
 
The following screen says the update was successfully downloaded, even though no
network activity has taken place. Restart button restarts Deer Park.

Comment 1

[Gary Elshaw]

Apologies. Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4)
Gecko/20050804 Firefox/1.0+ on OS X 10.4.2

Comment 2

[Gary Elshaw]

Appears to be broken in Thunderbird version 1.0+ (20050804) as well.

Comment 3

[Darin Fisher]

WORKSFORME... try again?

Comment 4

[Gary Elshaw]

(In reply to comment #3)
> WORKSFORME... try again?

Hi Darin, i ran through the whole quit, relogin process and still no dice. Has
the update URL changed? Maybe i hould download the nightly rather than the
update and try again

Comment 5

[Gary Elshaw]

tried packaged nightly Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b4) Gecko/20050804 Firefox/1.0+ and a fresh profile - same result.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Tried some builds: the updater finds an update for the 2005080405 build, but not
for the 2005080408 and the 2005080421 build.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050804
Firefox/1.0+ ID:2005080421

Comment 7

[Ria Klaassen (not reading all bugmail)]

For the 2005080405 build the updater finds a 2005080406 update.

Comment 8

[[e-mail]]

I have the same problem. Update dialog acts as if there is a new update without
even checking network. It seems like the code is disconnected with the UI.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050804
Firefox/1.0+

Comment 9

[Darin Fisher]

Ben: any thoughts on this?  sounds like a recent regression, but i can't seem to
repro it on my systems.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Looking...

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Looks like I misunderstood this binding when I patched it last time - there's a
separate binding for wizard buttons on OS X. This patch adds the |extra1|
button to the MacOSX wizard buttons too, and removes the MacOS X specific
handling from the "other platforms" section since Mac will never build that
code.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. 

Comment 13

[Gary Elshaw]

Ben, does the fix for the update manager include Thunderbird?