303491 - Groupbox underline is white directly under the caption

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Look at Preferences > Advanced > General.

Result: Each groupbox has a long underline under the caption.  The underline
turns white when it is directly under the caption but is a darker gray elsewhere.

Expected: dark gray underline all the way across (?)

Comment 1

[John Daggett (:jtd)]

Attachment: security prefs tab screenshot

This seems to be fixed in the latest FF3 trunk.  However, on the Security tab the bottom of the groupbox line for "Warning Messages" is cut off.  See attached screenshot.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082019 Minefield/3.0a8pre

Comment 2

[Jesse Ruderman]

Attachment: screenshot - still happens on mac

Comment 3

[philippe (part-time)]

This still happens, both Shiretoko and Minefield builds.

In the forums, Aronnax! (Grapple Themes )suggests:

> #paneAdvanced caption {
> border-bottom: 1px solid #e0e0e0;
> }
> would fix it.

> Superior would be something more global like :
> groupbox > caption {
> border-bottom: 1px solid #e0e0e0;
> }
> Which unfortunately not do the job. Do you have an idea?

http://forums.mozillazine.org/viewtopic.php?p=6564015#p6564015

Dão, can you have a look ?
I, unfortunately won't have time to dig deeper into this, atm.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This isn't going to block our release, but if someone submits a safe and tested patch and nominates it for approval, we can try to get it into this or a 3.5.x release.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

What a mess. I couldn't resist doing some cleanup.

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 389364 [details] [diff] [review]
patch


> prefpane .groupbox-title {
>-  background: url("chrome://global/skin/50pct_transparent_grey.png") repeat-x bottom left;
>+  border-bottom: 1px solid rgba(50%,50%,50%,.5);

This has the side-effect that the first group box in the Content pane (#miscGroup) will get a line even though it doesn't have a caption. This didn't happen with the background style because .groupbox-title had a height of 0, so the background didn't show.
I think the border should be set on the caption, not on .groupbox-title. That would fix it.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 389364 [details] [diff] [review]
patch

The caption doesn't take the whole width, so without further changes that won't work either.

Comment 9

[Dão Gottwald [:dao]]

Attachment: patch v2

stupid image :(

Comment 10

[Markus Stange [:mstange]]

(In reply to comment #8)
> (From update of attachment 389364 [details] [diff] [review])
> The caption doesn't take the whole width, so without further changes that won't
> work either.

Oh, yeah, good point. I think we should fix that in a followup bug.

Comment 11

[Markus Stange [:mstange]]

Attachment: after screenshot

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 389637 [details]
after screenshot

Looks much better than before.  Eventually we should be following the correct layout (labels on left, and controls on right), so that we don't need the lines at all.

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e50cbaef1d8f

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Titles on left, controls on right

As mentioned in the previous comment, eventually this layout would removed our need to use not entirely native lines.