303500 - make NS_NOTYETIMPLEMENTED a warning and not assertion

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect, P5)

Description

[Bob Clary [:bc] (inactive)]

Currently NS_NOTYETIMPLEMENTED calls nsDebug::Assertion. When assertions become
fatal, this will need to be changed to a warning. Unfortunately nsDebug::Warning
does not take an additional string such as "NotYetImplemented" which is
currently passed to nsDebug::Assertion. It would be nice to have a
nsDebug::Warning that took an additional parameter so that it could be used when
switching macros like NS_NOTYETIMPLEMENTED from assertion to warning.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Perhaps we need two separate things here... there are places where NS_NOTYETIMPLEMENTED should absolutely assert.

Comment 2

[Jesse Ruderman]

bz, that would be nice, so I could file bugs when I hit the ones that "should assert" :)

Comment 3

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 4

[Chris Peterson [:cpeterson]]

I am proposing to replace NS_NOTYETIMPLEMENTED with MOZ_ASSERT_UNREACHABLE, a fatal debug assertion, in bug 1416164. This is safe because NS_NOTYETIMPLEMENTED isn't hit during a debug Try run or when browsing some popular top sites.