Closed Bug 303501 Opened 19 years ago Closed 19 years ago

make SVG NS_NOTYETIMPLEMENTED messages more meaningful

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bc, Unassigned)

Details

Attachments

(1 file)

When tracking assertions, simple asserts with "Write me!" don't really help in
easily determining the location of the problem. While asserts do show the
file/line number, these can change over time making automatic historical
comparisons difficult.
Attached patch patchSplinter Review
Patch to make SVG's NS_NOTYETIMPLEMENTED messages clearer and to standardize
the return values to NS_ERROR_NOT_IMPLEMENTED.
Attachment #191659 - Flags: superreview?(tor)
Attachment #191659 - Flags: review?(alex)
Attachment #191659 - Flags: review?(alex) → review+
Attachment #191659 - Flags: superreview?(tor) → superreview+
requesting approval for 1.8b4 for this low risk patch which will help automated
qa of assertion messages.
Flags: blocking1.8b4?
Flags: blocking1.8b4?
Comment on attachment 191659 [details] [diff] [review]
patch

approved.
(bob, for approval requests, use the patch flag rather than the bug flag.
thanks.)
Attachment #191659 - Flags: approval1.8b4+
checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: