Closed
Bug 303501
Opened 20 years ago
Closed 20 years ago
make SVG NS_NOTYETIMPLEMENTED messages more meaningful
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: bc, Unassigned)
Details
Attachments
(1 file)
|
45.52 KB,
patch
|
jwatt
:
review+
tor
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
When tracking assertions, simple asserts with "Write me!" don't really help in
easily determining the location of the problem. While asserts do show the
file/line number, these can change over time making automatic historical
comparisons difficult.
|
Reporter | |
Comment 1•20 years ago
|
||
Patch to make SVG's NS_NOTYETIMPLEMENTED messages clearer and to standardize
the return values to NS_ERROR_NOT_IMPLEMENTED.
|
|
Reporter | |
Updated•20 years ago
|
Attachment #191659 -
Flags: superreview?(tor)
Attachment #191659 -
Flags: review?(alex)
|
||
Updated•20 years ago
|
Attachment #191659 -
Flags: review?(alex) → review+
Attachment #191659 -
Flags: superreview?(tor) → superreview+
|
|
Reporter | |
Comment 2•20 years ago
|
||
requesting approval for 1.8b4 for this low risk patch which will help automated
qa of assertion messages.
Flags: blocking1.8b4?
|
||
Updated•20 years ago
|
Flags: blocking1.8b4?
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 191659 [details] [diff] [review]
patch
approved.
(bob, for approval requests, use the patch flag rather than the bug flag.
thanks.)
Attachment #191659 -
Flags: approval1.8b4+
|
|
Reporter | |
Comment 4•20 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•