Closed Bug 303505 Opened 16 years ago Closed 8 years ago

make toolkit intl nsCharsetMenu.cpp NS_NOTYETIMPLEMENTED messages more meaningful

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: bc, Assigned: bc)

Details

Attachments

(1 file, 1 obsolete file)

When tracking assertions, simple asserts with "Write me!" don't really help in
easily determining the location of the problem. While asserts do show the
file/line number, these can change over time making automatic historical
comparisons difficult.
Attached patch patch (obsolete) — Splinter Review
Attachment #191663 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #191663 - Flags: review?(bryner)
Attachment #191663 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Assignee: nobody → bob
Attachment #191663 - Flags: review?(bryner) → review+
Component: XP Miscellany → General
QA Contact: brendan → general
Hello there,

My friend and I are interested in helping out.  Is this bug still active?  If so, where/how do we begin?

Thanks.
Henry, sorry for the lack of response. This is a simple editing job that fell off my radar. I'll go ahead and finish up, but if you are still interested in helping out and haven't gotten started yet, please either email me directly or join irc.mozilla.org and give me a ping. I can get you started with the basics and point you to some other people who may be able to help with more technical issues. My irc nick is bc.
Status: NEW → ASSIGNED
Summary: make xpfe intl NS_NOTYETIMPLEMENTED messages more meaningful → make toolkit intl nsCharsetMenu.cpp NS_NOTYETIMPLEMENTED messages more meaningful
Attached patch patch v2Splinter Review
the file has moved to toolkit/components/intel/nsCharsetMenu.cpp

bz, not sure whom to ask for a review. Simple change to add the method names to the NS_NOTYETIMPLEMENTED calls.
Attachment #191663 - Attachment is obsolete: true
Attachment #739631 - Flags: review?(bzbarsky)
Comment on attachment 739631 [details] [diff] [review]
patch v2

Sure.
Attachment #739631 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/5622c699bfc7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.