Closed Bug 303520 Opened 20 years ago Closed 20 years ago

Cannot select added language in language preferences dialog if added when the list can scroll

Categories

(Firefox :: Settings UI, defect)

2.0 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2 beta1

People

(Reporter: u45550, Assigned: Gavin)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.10) Gecko/20050717 Firefox/1.0.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.10) Gecko/20050717 Firefox/1.0.6 A newly added language cannot be moved up/down with the buttons if the end of the language list cannot be seen at the time of adding the new language. The new language also cannot be selected. This sounds strange but try it! Reproducible: Always Steps to Reproduce: 1. Open Preferences => Language 2. Add some languages so that the list so long, that a scrollbar is shown 3. Scroll up the list and select an item, so that the end of the list is not shown 4. Add a new language Actual Results: The language is added to the end of the list but the new language cannot be selected in the list. Expected Results: The language should be added and the new language should be selectable.
Confirmed bug in Deer Park Alpha 2, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+. Nice catch.
So can we close it as duplicate? Which bug number is it for Deer Park Alpha 2?
This looks very similar to the issue in bug 279497.
This bug also exists in 1.5 beta 1. A workaround is to click Ok and get back into the Languages dialog box; the bottom language is now selectable.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Summary: cannot move up new language in preferences dialog → Cannot select added language in language preferences dialog if added when the list can scroll
Version: unspecified → Trunk
Attached patch PatchSplinter Review
Ensure the element is visible before trying to select it.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #195663 - Flags: review?(mconnor)
Whiteboard: [patch-r?]
Attachment #195663 - Flags: review?(mconnor) → review+
Whiteboard: [patch-r?] → [patch-r+][checkin needed]
mozilla/browser/components/preferences/languages.js; new revision: 1.9; previous revision: 1.8
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+][checkin needed]
Target Milestone: --- → Firefox1.5
Target Milestone: Firefox1.5 → Firefox1.6-
Attachment #195663 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #195663 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
mozilla/browser/components/preferences/languages.js 1.6.2.3
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 2 → Firefox 2 beta1
Version: Trunk → 2.0 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: