The bug entry page does not use localised terms for statuses

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Interface
--
minor
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Wurblzap, Assigned: Wurblzap)

Tracking

2.20
Bugzilla 2.20
Bug Flags:
approval +
approval2.20 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
This is similar to bug 293767, but for the bug entry page.
(Assignee)

Comment 1

13 years ago
Created attachment 191678 [details] [diff] [review]
Patch
Attachment #191678 - Flags: review?(myk)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
Comment on attachment 191678 [details] [diff] [review]
Patch

>-        [% " selected=\"selected\"" IF x == default.${sel.name} %]>[% x FILTER html -%]
>-      </option>
>+        [% " selected=\"selected\"" IF x == default.${sel.name} %]>
>+        [% IF sel.name == "bug_status" %]
>+          [% status_descs.${x} FILTER html %]
>+        [% ELSE %]
>+          [% x FILTER html %]
>+        [% END %]</option>

Nit: you probably don't need to enclose x in curly brackets.

Nit: this would be better as:

	[% " selected=\"selected\"" IF x == default.${sel.name} %]>
	[% IF sel.name == "bug_status" -%]
	  [% status_descs.${x} FILTER html -%]
	[% ELSE -%]
	  [% x FILTER html -%]
	[% END -%]
      </option>

Then the line breaks and indenting for "</option>" would represent the
structure of the code, and you'd be using the right tool (directive-specific
post-chomp) to remove whitespace between the option label and the closing
option tag, if necessary.

Otherwise looks great.	Another step towards localization manna. r=myk
Attachment #191678 - Flags: review?(myk) → review+
(Assignee)

Comment 3

12 years ago
Created attachment 192848 [details] [diff] [review]
Patch 1.1

> Nit: you probably don't need to enclose x in curly brackets.

True. Dropped 'em.

> Then the line breaks and indenting for "</option>" would represent the
> structure of the code, and you'd be using the right tool (directive-specific
> post-chomp) to remove whitespace between the option label and the closing
> option tag, if necessary.

Well, but it doesn't work. The line break gets post-chomped, but the whitespace
at the beginning of the following line isn't. So in order to get rid of all
blanks in there, I left it the way it is for now.

I don't really know whether I'm supposed to carry forward r+ on this one or
not.
Attachment #191678 - Attachment is obsolete: true
Attachment #192848 - Flags: review?(myk)
Attachment #192848 - Flags: review?(myk) → review+
(Assignee)

Updated

12 years ago
Flags: approval?
Flags: approval2.20?
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+

Comment 4

12 years ago
tip:

Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.53; previous revision: 1.52
done

2.20rc2:

Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.51.2.1; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.