303527 - The bug entry page does not use localised terms for statuses

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Marc Schumann [:Wurblzap]]

This is similar to bug 293767, but for the bug entry page.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 191678 [details] [diff] [review]
Patch

>-        [% " selected=\"selected\"" IF x == default.${sel.name} %]>[% x FILTER html -%]
>-      </option>
>+        [% " selected=\"selected\"" IF x == default.${sel.name} %]>
>+        [% IF sel.name == "bug_status" %]
>+          [% status_descs.${x} FILTER html %]
>+        [% ELSE %]
>+          [% x FILTER html %]
>+        [% END %]</option>

Nit: you probably don't need to enclose x in curly brackets.

Nit: this would be better as:

	[% " selected=\"selected\"" IF x == default.${sel.name} %]>
	[% IF sel.name == "bug_status" -%]
	  [% status_descs.${x} FILTER html -%]
	[% ELSE -%]
	  [% x FILTER html -%]
	[% END -%]
      </option>

Then the line breaks and indenting for "</option>" would represent the
structure of the code, and you'd be using the right tool (directive-specific
post-chomp) to remove whitespace between the option label and the closing
option tag, if necessary.

Otherwise looks great.	Another step towards localization manna. r=myk

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.1

> Nit: you probably don't need to enclose x in curly brackets.

True. Dropped 'em.

> Then the line breaks and indenting for "</option>" would represent the
> structure of the code, and you'd be using the right tool (directive-specific
> post-chomp) to remove whitespace between the option label and the closing
> option tag, if necessary.

Well, but it doesn't work. The line break gets post-chomped, but the whitespace
at the beginning of the following line isn't. So in order to get rid of all
blanks in there, I left it the way it is for now.

I don't really know whether I'm supposed to carry forward r+ on this one or
not.

Comment 4

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.53; previous revision: 1.52
done

2.20rc2:

Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.51.2.1; previous revision: 1.51
done