303550 - Bug lists trigger standards compliance mode in Gecko, causing CLOSED bugs not to be lined through in bug lists any more

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Marc Schumann [:Wurblzap]]

Bugzilla 2.20rc1 bug lists happily trigger standards compliance mode in
Firefox 1.0.6. This results in bugs in the CLOSED state not to be lined through
any more.

The reason consists of two effects of standards compliance mode:
 o CSS class and id names are case sensitive as per
   http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.2
 o CSS text-decoration on <tr> is not inherited to <td>

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

I don't know whether the second part is a bug. This patch takes care of both.

We still need bz_closed because GetBugLink in globals.pl issues this class for
bugs in non-open states (not only for the CLOSED state).

Comment 2

[Marc Schumann [:Wurblzap]]

This still works in 2.18 (see
http://landfill.bugzilla.org/bugzilla-2.18-branch/buglist.cgi?bug_status=CLOSED).

Comment 3

[Frédéric Buclin]

Comment on attachment 191685 [details] [diff] [review]
Patch

This fixes the problem for me: r=LpSolit for both 2.20 and tip.

Marc, can you explain me why 2.18.3 is not affected? By looking at the source
code of a buglist page, it looks really similar the one obtained from 2.20+.

Comment 4

[Frédéric Buclin]

(In reply to comment #1)
> We still need bz_closed because GetBugLink in globals.pl issues this class for
> bugs in non-open states (not only for the CLOSED state).

GetBugLink is not the only one to use bz_closed, see for instance "FILTER
closed()" in Templates.pm.

Comment 5

[Frédéric Buclin]

tip:

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.14; previous revision: 1.13
done

2.20rc2:

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.12.4.1; previous revision: 1.12
done