303569 - Searching using boolean charts for Hours Worked should sum up all hours worked

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect)

Description

[Bryce McGowan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913

Searching for bugs with "Advanced Searching Using Boolean Charts:" and having
the first column set to "Hours Worked", the second column to "is eual to", and
the third column set to "0" (zero), the buglist displayed after the search has
bugs listed that have actually had hours worked. I could not find any duplicates
of this bug, nor saw this as fixed in any release notes. I verified that this
still occurs at landfill.bugzilla.org with the 2.18.3 and 2.20 versions. Also
tried searcing for 0.00 and 0.0000 instead of just 0.

Reproducible: Always

Steps to Reproduce:
1.Go to bugzilla Query/Search page
2.Use Adv. Bool. Charts and choose "Hours Worked", "is equal to", "0" (zero)
3.Click 'Search' button. 

Actual Results:  
Bug list returns with some bugs having hours worked of 0 (zero), and also some
bugs that have hours worked greater than 0 (zero). 

Expected Results:  
Should have returned a bug list of only bugs that have 0 (zero) hours worked.

Comment 1

[Marc Schumann [:Wurblzap]]

I can reproduce.

It seems that the search fails to sum up the hours worked. If somebody adds a
comment to the bug without entering hours worked for this step, then the search
will match.

Comment 2

[Marc Schumann [:Wurblzap]]

Tweaking the summary a little

Comment 3

[Max Kanat-Alexander]

Yeah, time-tracking should work well for the 2.22 release, I think. This is slightly borderline whether or not it's a blocker, but I think I'll mark it as blocking.

I wouldn't object to seeing this bug fixed in the 2.20 series, also, if the fix isn't too invasive. :-)

Comment 4

[Max Kanat-Alexander]

Okay, thinking about it, I actually wouldn't *block* the release on this. But it would still be nice to have it fixed for 2.22.

Comment 5

[Frédéric Buclin]

We are freezing the code for 3.0 in two weeks and we don't expect this bug to be fixed on time.

Comment 6

[Jeff Hedlund]

I'll take this bug.  I've got a patch ready.

Comment 7

[Jeff Hedlund]

Attachment: patch v1

Comment 8

[Jeff Hedlund]

Comment on attachment 264525 [details] [diff] [review]
patch v1

It's been a while since I've posted a patch - are we still doing a minimum of 2 reviews?

Comment 9

[Max Kanat-Alexander]

(In reply to comment #8)
> (From update of attachment 264525 [details] [diff] [review])
> It's been a while since I've posted a patch - are we still doing a minimum of 2
> reviews?

  No, it's one review and then an approval:

  http://www.bugzilla.org/docs/contributor.html

Comment 10

[Max Kanat-Alexander]

I don't think I'm the best reviewer here. Ask Joel instead, for now.

Comment 11

[Jeff Hedlund]

Comment on attachment 264525 [details] [diff] [review]
patch v1

Requesting review from Joel instead.

Comment 12

[Frédéric Buclin]

Comment on attachment 264525 [details] [diff] [review]
patch v1

>+             push(@supptables, "INNER JOIN (SELECT bug_id, " .
>+                               "            SUM(work_time) As work_time" .
>+                               " FROM longdescs GROUP BY bug_id) AS $table " .
>                                "ON $table.bug_id = bugs.bug_id");

Bitrotten and you cannot use GROUP BY as is. You have to use sql_group_by() instead.

Comment 13

[Max Kanat-Alexander]

I did this on trunk! :-)