303587 - Bad html entity decode algorithm

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Leung Wing Chung]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

Below is feeditem.js lines 345-350:

  // the subject may contain HTML entities.
  // Convert these to their unencoded state. i.e. & becomes '&'
  title = title.replace(/&lt;/g, '<');
  title = title.replace(/&gt;/g, '>');
  title = title.replace(/&amp;/g, '&');
  title = title.replace(/&quot;/g, '"');

Since & is decoded prior to ", &amp;quot; will be wrongly decoded to " rather
than &quot;

So the code should be modified as follows:

  title = title.replace(/&lt;/g, '<');
  title = title.replace(/&gt;/g, '>');
  title = title.replace(/&quot;/g, '"');
  title = title.replace(/&amp;/g, '&');


Reproducible: Always

Steps to Reproduce:

Comment 1

[Leung Wing Chung]

A similar bug is found on the same source file, lines 199-204. Again, switching
the last two lines fix the bug.

    // HACK ALERT: before we give up, try to work around an entity escaping bug
in RDF
    // See Bug #258465 for more details
    itemURI = itemURI.replace(/&lt;/g, '<');
    itemURI = itemURI.replace(/&gt;/g, '>');
    itemURI = itemURI.replace(/&amp;/g, '&');
    itemURI = itemURI.replace(/&quot;/g, '"');

Comment 2

[Scott MacGregor]

Attachment: the fix