Closed
Bug 303623
Opened 19 years ago
Closed 19 years ago
gcc335 needs extra cast in XPCOM glue code
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mkaply)
Details
Attachments
(1 file)
|
604 bytes,
patch
|
mkaply
:
review+
mkaply
:
superreview+
mkaply
:
approval1.8b4+
|
Details | Diff | Splinter Review |
When compiling xpcom/glue/standalone/nsGlueLinkingOS2.cpp with GCC 3.3.5-r1 I get the error nsGlueLinkingOS2.cpp G:/MozCompile/trunk/mozilla/xpcom/glue/standalone/nsGlueLinkingOS2.cpp: In function `nsresult (* XPCOMGlueLoad(const char*))(XPCOMFunctions*, const char*)': G:/MozCompile/trunk/mozilla/xpcom/glue/standalone/nsGlueLinkingOS2.cpp:131: error: invalid conversion from `nsresult (**)(XPCOMFunctions*, const char*)' to `int (__attribute__((system)) **)()' make.exe[5]: *** [nsGlueLinkingOS2.o] Error 1 It seems that 3.3.5 is more picky about type checking than 3.3.2.
|
Reporter | |
Comment 1•19 years ago
|
||
This gets me through the problem
Attachment #191741 -
Flags: review?(mozilla)
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 191741 [details] [diff] [review] Extra cast r/sr/a=mkaply
Attachment #191741 -
Flags: superreview+
Attachment #191741 -
Flags: review?(mozilla)
Attachment #191741 -
Flags: review+
Attachment #191741 -
Flags: approval1.8b4+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fix checked in. Thanks for the push on this one.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•