Closed Bug 30365 Opened 24 years ago Closed 24 years ago
File Transport::Open Input Stream takes 1 .10 sec out of (9 .9secs + dll loadtime)
Function % #calls secs ============================================================= nsFileTransport::OpenInputStream 100 51 1.10 nsLocalFile::Exists 89.89 51 0.99 PR_ExitMonitor 9.61 51 0.11 If I eliminate the Exists() call in nsFileTransport::OpenInputStream() I get about a 2 to 3 sec improvement in startup. Dont know if my tools are lying.
warren, neeti has the fix in her tree and the timings. Hence I assigned the bug to her. You need to decide if this is ok to do.
I have a bug on this already, but can't seem to find it now. Let's see the fix.
*** Bug 30364 has been marked as a duplicate of this bug. ***
Reassigning to Warren to decide if the fix is ok.
Assignee: neeti → warren
No way. I know this Exists call was added to fix another bug, I don't have time to do the archeology now to figure out the bug #.
Target Milestone: M17 → M18
This code has completely changed now. OpenInputStream now uses the nsIStreamIO's GetInputStream method. There still may be a problem here since nsFileIO::GetInputStream calls IsDirectory (which I believe also does a stat), but that can't be avoided. Marking invalid now.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.