30365 - nsFileTransport::OpenInputStream takes 1.10 sec out of (9.9secs + dll loadtime)

Status: VERIFIED INVALID

(Core :: Networking, defect, P3)

Description

[Suresh Duddi (gone)]

Function				%	#calls	secs
=============================================================
nsFileTransport::OpenInputStream	100	51	1.10
  nsLocalFile::Exists			 89.89	51	0.99
  PR_ExitMonitor			 9.61	51	0.11

If I eliminate the Exists() call in nsFileTransport::OpenInputStream() I get 
about a 2 to 3 sec improvement in startup. Dont know if my tools are lying.

Comment 1

[Suresh Duddi (gone)]

warren, neeti has the fix in her tree and the timings. Hence I assigned the bug 
to her. You need to decide if this is ok to do.

Comment 2

[Warren Harris]

I have a bug on this already, but can't seem to find it now. Let's see the fix.

Comment 3

[neeti]

*** Bug 30364 has been marked as a duplicate of this bug. ***

Comment 4

[neeti]

Attachment: created an attachment for the fix

Comment 5

[neeti]

Reassigning to Warren to decide if the fix is ok.

Comment 6

[Warren Harris]

No way. I know this Exists call was added to fix another bug, I don't have time 
to do the archeology now to figure out the bug #.

Comment 7

[Warren Harris]

post-beta2

Comment 8

[Warren Harris]

This code has completely changed now. OpenInputStream now uses the nsIStreamIO's 
GetInputStream method. There still may be a problem here since 
nsFileIO::GetInputStream calls IsDirectory (which I believe also does a stat), 
but that can't be avoided. 

Marking invalid now.

Comment 9

[Tom Everingham]

verified INVALID