303675 - downloads fail silently if the default download path is invalid, e.g. leads to a removed drive

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Ian Neal]

SM version of bug 270557 - summary says it all :-)

Comment 1

[Ian Neal]

Attachment: Simple patch v0.1

This patch
* Adds dir.exists() checks to the relevant places in nsHelperAppDlg.js and
contentAreaUtils.js

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 191801 [details] [diff] [review]
Simple patch v0.1

+	 if (dir && dir.exists() && autoDownload) {

autoDownload is faster to check, so I'd check that before .exists(). it's also
more likely to be false.

(both files)

Comment 3

[Ian Neal]

Attachment: Revised patch v0.2

Changes since v0.1:
* Addressed reviewer's comments wrt order of checks

Carrying forward r= and requesting sr=

Comment 4

[[e-mail]]

Comment on attachment 191809 [details] [diff] [review]
Revised patch v0.2

I think that it would be even clearer still if autoDownload was tested first.

Comment 5

[Ian Neal]

Attachment: Tweaked patch v0.3 (Checked in)

Changes since v0.2
* Shuffled order of checks as per Neil's comments

Carrying forward r= and sr=

Requesting a= for very low risk patch.

Comment 6

[Ian Neal]

Comment on attachment 191871 [details] [diff] [review]
Tweaked patch v0.3 (Checked in)

Checking in
embedding/components/ui/helperAppDlg/nsHelperAppDlg.js;
new revision: 1.69; previous revision: 1.68
xpfe/communicator/resources/content/contentAreaUtils.js;
new revision: 1.134; previous revision: 1.133
done

Comment 7

[Jo Hermans]

*** Bug 202735 has been marked as a duplicate of this bug. ***

Comment 8

[Jo Hermans]

*** Bug 257052 has been marked as a duplicate of this bug. ***

Comment 9

[WADA:World Anti-bad-Duping Agency]

There is an older Bug 142664(browser.download.dir case) in addition to DUP
closed Bug 202735 and Bug 257052.
Ian Neal, does your patch fix Bug 142664 too?
How about another Bug 240644 case(mail.compose.attach.dir case)? 

Comment 10

[Ian Neal]

Bug 142664 is not one I can reproduce, but it is probably best you comment in
the bugs mentioned than in here.