303684 - Feedview: The generated HTML is invalid

Status: RESOLVED INVALID

(Firefox Graveyard :: RSS Discovery and Preview, enhancement)

Description

[Erik Arvidsson]

The XSLT that generates XML for a feed produces very bad HTML. The HTML uses an
<a> element where an <h2> would be better. It uses empty <p> elements and lots
of <br/> (as well as p elements inside other p elements).

This makes the resulting HTML hard to style and it makes screen readers totally
confused.

This is the currently generated XHTML:

<div class="article" date="2005-08-05T19:49:33-08:00" description="...">		<a
href="http://www.mozillazine.org/talkback.html?article=7093">Mitchell Baker
Quizzed on Mozilla Corporation</a><span class="date">Sat, 06 Aug @
05:49</span><p><p/><p>        </p><p>The Mozilla project's Chief Lizard Wrangler
Mitchell Baker was interviewed at the OSCON 2005 conference on Thursday.
Following Wednesday's  surprise announcement of the creation of the Mozilla
Corporation, it's not surprising that most of conference chair Nat Torkington's
questions focused on this new taxable subsidiary of the Mozilla
Foundation.</p><p>        </p><p>Mitchell, who is now the President of the
Mozilla Corporation, explained why the Mozilla Foundation decided to create a
commercial division and what it will do. She also recalled some history,
describing the events that led up to the initial launch of the Mozilla
Foundation in 2003 and discussing how mozilla.org originally started under
Netscape in 1998. Mitchell also talked about why she believes Mozilla Firefox
could have only come from an open-source project and what the future holds for
Mozilla.</p><p>        </p><p>An audio recording of Mitchell's interview is
available from the Mozilla Foundation Reorganization page as either a direct MP3
download or a podcast. The file is 29 megabytes in size and lasts for 15 minutes
and 51 seconds.</p><p>        </p><p>Talkback</p><p>      </p></p></div>
	
It should look somthing like this:

<div class="entry">
   <h2 class="title"><a href="...">Title</a> <span class="date">...</span></h2>
   <div class="summary">...</div> <!-- summary is plain text -->
   <div class="content">
      ...
   </div>
</div>
   <p>...</p>

Comment 1

[Peter van der Woude [:Peter6]]

near bottom of document

>> <script>          
>>     if (document.getEleme ......... 

what kind of script ?

Comment 2

[Grey Nicholson (they/them)]

Requesting blocking1.8b4 since invalid HTML sucks (I'd prefer to request
blocking-aviary1.5 or blocking1.8 but neither is available).

Comment 3

[Mike Connor [:mconnor]]

minusing, we're backing away from this feature now.

Comment 4

[Phil Ringnalda (:philor)]

-> INVA, no reason to assume Son of Feedview will have the same invalid HTML
(much of that was from Feedview's HTML-stripping code), and we can always start
with a fresh bug if it does have similar or new invalid HTML.

Comment 5

[Tanner M. Young [:tmyoung]]

Resetting QA Contact to default.