303691 - Eliminate deprecated Bugzilla::DB routines from importxml.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Teemu Mannermaa (:wicked)]

These lines need to rewritten to use DBI:

importxml.pl:312:        push (@values, SqlQuote($bug_fields{$field}));
importxml.pl:318:      push (@values, SqlQuote($bug_fields{'delta_ts'}));
importxml.pl:326:      push (@values, SqlQuote($bug_fields{'bug_file_loc'}));
importxml.pl:331:      push (@values, SqlQuote($bug_fields{'short_desc'}) );
importxml.pl:392:    push (@values, SqlQuote($version[0]) );
importxml.pl:396:    push (@values, SqlQuote($::versions{$product[0]}->[0]));
importxml.pl:403:    push (@values, SqlQuote($priority[0]) );
importxml.pl:406:    push (@values, SqlQuote("P3"));
importxml.pl:415:    push (@values, SqlQuote($platform[0]) );
importxml.pl:418:    push (@values, SqlQuote("Other") );
importxml.pl:428:    push (@values, SqlQuote($opsys[0]) );
importxml.pl:431:    push (@values, SqlQuote("other"));
importxml.pl:442:      push (@values, SqlQuote($tm[0]) );
importxml.pl:445:      SendSQL("SELECT defaultmilestone FROM products " .
importxml.pl:446:              "WHERE name = " . SqlQuote($product[0]));
importxml.pl:447:      my $tm = FetchOneColumn();
importxml.pl:448:      push (@values, SqlQuote($tm));
importxml.pl:462:    push (@values, SqlQuote($severity[0]) );
importxml.pl:465:    push (@values, SqlQuote("normal"));
importxml.pl:475:    push (@values, SqlQuote($reporterid));
importxml.pl:478:    push (@values, SqlQuote($exporterid));
importxml.pl:493:    push (@values,
SqlQuote(login_to_id($bug_fields{'assigned_to'})));
importxml.pl:496:    push (@values, SqlQuote($exporterid) );
importxml.pl:512:    push (@values, SqlQuote($resolution[0]) );
importxml.pl:522:    push (@values, SqlQuote("NEW"));
importxml.pl:531:    push (@values, SqlQuote("NEW"));
importxml.pl:541:    push (@values, SqlQuote($status[0]));
importxml.pl:545:    push (@values, SqlQuote("NEW"));
importxml.pl:560:      SendSQL("SELECT initialqacontact FROM components,
products " .
importxml.pl:562:              " AND products.name = " . SqlQuote($product[0])
.importxml.pl:563:              " AND components.name = " .
SqlQuote($component[0]) );
importxml.pl:564:      $qa_contact = FetchOneColumn();
importxml.pl:578:  SendSQL($query);
importxml.pl:585:        SendSQL("insert into cc (bug_id, who) values ($id, " .
SqlQuote($uid) .")");
importxml.pl:602:        SendSQL("INSERT INTO keywords (bug_id, keywordid)
VALUES ($id, $i)");
importxml.pl:613:  SendSQL("INSERT INTO longdescs (bug_id, who, bug_when,
thetext) VALUES " .
importxml.pl:614:    "($id, $exporterid, now(), " . SqlQuote($long_description)
. ")");

move.pl:83:    SendSQL("INSERT INTO bugs_activity " .
move.pl:88:    SendSQL("INSERT INTO bugs_activity " .
move.pl:92:    SendSQL("UPDATE bugs SET bug_status =\"RESOLVED\",
move.pl:106:    SendSQL("INSERT INTO longdescs (bug_id, who, bug_when, thetext)
VALUES " .
move.pl:107:        "($id,  $exporterid, now(), " . SqlQuote($comment) . ")");

Comment 1

[Frédéric Buclin]

move.pl doesn't exist anymore. Updating the summary accordingly.

Comment 2

[Frédéric Buclin]

All deprecated routines have been removed as part of the rewrite of importxml.pl, see bug 285614. Fixed!