303702 - Eliminate deprecated Bugzilla::DB routines from editcomponents.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Teemu Mannermaa (:wicked)]

These lines need to rewritten to use DBI:

editcomponents.cgi:57:    SendSQL("SELECT name
editcomponents.cgi:59:             WHERE name = " . SqlQuote($prod));
editcomponents.cgi:60:    return FetchOneColumn();
editcomponents.cgi:83:    SendSQL("SELECT components.name
editcomponents.cgi:87:             WHERE products.name = " . SqlQuote($prod) . "
editcomponents.cgi:88:             AND components.name = " . SqlQuote($comp));
editcomponents.cgi:89:    return FetchOneColumn();
editcomponents.cgi:143:        SendSQL("SELECT products.name,
products.description, COUNT(bug_id)
editcomponents.cgi:149:        SendSQL("SELECT products.name, products.description
editcomponents.cgi:154:    while ( MoreSQLData() ) {
editcomponents.cgi:158:        my ($name, $description, $bug_count) =
FetchSQLData();
editcomponents.cgi:190:        SendSQL("SELECT name, description, initialowner,
editcomponents.cgi:198:        SendSQL("SELECT name, description, initialowner,
initialqacontact
editcomponents.cgi:205:    while (MoreSQLData()) {
editcomponents.cgi:209:            = FetchSQLData();
editcomponents.cgi:311:              $initialqacontact ne '' ?
SqlQuote($initialqacontactid) : 'NULL';
editcomponents.cgi:314:    SendSQL("INSERT INTO components ( " .
editcomponents.cgi:318:          SqlQuote($component) . "," .
editcomponents.cgi:319:          SqlQuote($description) . "," .
editcomponents.cgi:320:          SqlQuote($initialownerid) . "," .
editcomponents.cgi:386:    SendSQL("SELECT products.name, products.description,
editcomponents.cgi:397:            FetchSQLData();
editcomponents.cgi:415:    SendSQL("SELECT count(bug_id)
editcomponents.cgi:418:    $vars->{'bug_count'} = FetchOneColumn() || 0;
editcomponents.cgi:496:    SendSQL("SELECT products.name,
editcomponents.cgi:504:        $description) = FetchSQLData();
editcomponents.cgi:509:    SendSQL("SELECT count(*)
editcomponents.cgi:513:    $vars->{'bug_count'} = FetchOneColumn() || 0;
editcomponents.cgi:563:        SendSQL("UPDATE components
editcomponents.cgi:564:                 SET description=" .
SqlQuote($description) . "
editcomponents.cgi:580:        SendSQL("UPDATE components
editcomponents.cgi:581:                 SET initialowner=" .
SqlQuote($initialownerid) . "
editcomponents.cgi:596:              $initialqacontact ne '' ?
SqlQuote($initialqacontactid) : 'NULL';
editcomponents.cgi:598:        SendSQL("UPDATE components
editcomponents.cgi:617:        SendSQL("UPDATE components SET name=" .
SqlQuote($component) .

Comment 1

[GavinS]

These are all fixed in attachment#188970 [details] [diff] [review] on bug#255425

Comment 2

[Frédéric Buclin]

fixed by blocker