303703 - Eliminate deprecated Bugzilla::DB routines from editflagtypes.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Teemu Mannermaa (:wicked)]

These lines need to rewritten to use DBI:

editflagtypes.cgi:143:            SendSQL("SELECT name FROM groups WHERE id =
$gid");
editflagtypes.cgi:144:            $vars->{'type'}->{$group} = FetchOneColumn();
editflagtypes.cgi:251:    my $name = SqlQuote($cgi->param('name'));
editflagtypes.cgi:252:    my $description = SqlQuote($cgi->param('description'));
editflagtypes.cgi:253:    my $cc_list = SqlQuote($cgi->param('cc_list'));
editflagtypes.cgi:261:    SendSQL("SELECT MAX(id) FROM flagtypes");
editflagtypes.cgi:262:    my $id = FetchSQLData() + 1;
editflagtypes.cgi:265:    SendSQL("INSERT INTO flagtypes (id, name, description,
cc_list,
editflagtypes.cgi:310:    my $name = SqlQuote($cgi->param('name'));
editflagtypes.cgi:311:    my $description = SqlQuote($cgi->param('description'));
editflagtypes.cgi:312:    my $cc_list = SqlQuote($cgi->param('cc_list'));
editflagtypes.cgi:317:    SendSQL("UPDATE  flagtypes
editflagtypes.cgi:337:    SendSQL("
editflagtypes.cgi:350:    Bugzilla::Flag::clear(FetchOneColumn()) while
MoreSQLData();
editflagtypes.cgi:352:    SendSQL("
editflagtypes.cgi:364:    Bugzilla::Flag::clear(FetchOneColumn()) while
MoreSQLData();
editflagtypes.cgi:413:    SendSQL("SELECT name FROM flagtypes WHERE id = $id");
editflagtypes.cgi:414:    $vars->{'name'} = FetchOneColumn();
editflagtypes.cgi:416:    SendSQL("DELETE FROM flags WHERE type_id = $id");
editflagtypes.cgi:417:    SendSQL("DELETE FROM flaginclusions WHERE type_id = $id");
editflagtypes.cgi:418:    SendSQL("DELETE FROM flagexclusions WHERE type_id = $id");
editflagtypes.cgi:419:    SendSQL("DELETE FROM flagtypes WHERE id = $id");
editflagtypes.cgi:440:    SendSQL("UPDATE flagtypes SET is_active = 0 WHERE id =
$id");
editflagtypes.cgi:466:    SendSQL("SELECT 1 FROM flagtypes WHERE id =
$flagtype_id");
editflagtypes.cgi:467:    FetchOneColumn()
editflagtypes.cgi:557:      SendSQL("SELECT id FROM groups WHERE name = " .
SqlQuote($name));
editflagtypes.cgi:558:      my $gid = FetchOneColumn();

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.28; previous revision: 1.27
done