303737 - Feedview: The date is incorrect

Status: RESOLVED INVALID

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Erik Arvidsson]

The shown date is incorrect in some case because the day part is done in UTC but
the hours and minutes are done using local time

I found this bug because a post had this GMT string:

Wed, 13 Jul 2005 23:25:20 +0000

parsing this using js Date gives:

Thu Jul 14 2005 01:25:20 GMT+0200

so the Feedview displays:

Wed, 13 Jul @ 01:25


I guess this bug will be marked as invalid because the date time needs to be
localized anyway. But until the date time is is localized this is indeed a valid
bug.

Comment 1

[Adam Guthrie]

Dupe of bug 303647, no?

Comment 2

[Peter van der Woude [:Peter6]]

(In reply to comment #0)
can you give the url or attach a testcase Erik ?

(In reply to comment #1)
> Dupe of bug 303647, no?
I'm not sure it is

Comment 3

[Grey Nicholson (they/them)]

> (In reply to comment #1)
> > Dupe of bug 303647, no?
> I'm not sure it is
It's not - bug 303647 is about the format used to display the date/time, not the
actual value of the date/time.

Comment 4

[Erik Arvidsson]

Attachment: Test case

This is not a duplicate 303647 since 303647 is about improving the display of
the date. This bug is that it shows an incorrect date. Hopefully, by fixing the
localization issues of the date time display this bug can be closed.

Comment 5

[Grey Nicholson (they/them)]

Does the checkin from bug 304362 comment 10 improve or fix this?

Comment 6

[Mike Connor [:mconnor]]

minusing, we're backing away from this feature now.

Comment 7

[Erik Arvidsson]

(In reply to comment #5)

No, the fix for bug 304362 does not fix this.

The following code is in there and it is logically flawed because it uses GMT to
get the day but local time to get the hours and minutes and this leads to errors
as I've explained before

 70                     var day = d.toGMTString();
 71                     day = day.substring(0, 11);
 72                     
 73                     function padZeros(num) {
 74                       return num < 10 ? "0" + num : num;
 75                     }
 76                     divs[i].getElementsByTagName("span")[0].textContent =
 77                       day + " @ " + padZeros(d.getHours()) +  ":" +
padZeros(d.getMinutes());

This needs to either switch to use d.toString() or go the whole way and localize
the date.

Comment 8

[Teri]

I have http://charter.msn.com/  as a homepage. The date still reads Wed Sept 28th


  I have to use IE to see current home page. (ick:)
Thanks Teri

Comment 9

[Phil Ringnalda (:philor)]

Closing: Son of Feedview will have a real parser that shouldn't have this particular mistake.

Comment 10

[Tanner M. Young [:tmyoung]]

Resetting QA Contact to default.