303738 - Midair collision message says CC changes will be undone

Status: NEW

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Jesse Ruderman]

"This will cause all of the above changes to be overwritten, except for the
added comment(s)."

Added CC's, at least CC's added because a bug was marked as a dup, are also
preserved.  So the message should be "Except for added comment(s) and CC(s)".

Comment 1

[Jesse Ruderman]

See also bug 69447, "Make CC changes not cause midairs."

Comment 2

[Mike Cowperthwaite]

(In reply to comment #0)
> Added CC's, at least CC's added because a bug was marked as a dup, are also
> preserved.  

I just verified:  *all* CC's, not just dupe-added ones.

This is just a text-change request, right?

Comment 3

[timeless]

Attachment: maybe this works

Comment 4

[Frédéric Buclin]

Comment on attachment 275270 [details] [diff] [review]
maybe this works

>+        [% IF comments.size > start_at %]
>+          , except for the added comment(s)
>+          [% ", and " IF ccs_changed %]
>+        [% END %]
>+        [% IF ccs_changed %]
>+          , [% " and " IF comments.size > start_at %]
>+          changes to the cc list
>+        [% END %].

'and' is added twice if comments.size > start_at and ccs_changed = 1.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Any chance of an updated patch here?

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch to show that comments and cc list changes will be preserved in midair (v1)

Comment 7

[Frédéric Buclin]

Comment on attachment 652786 [details] [diff] [review]
Patch to show that comments and cc list changes will be preserved in midair (v1)

>+[% ccs_changed = 0 %]
>+[% FOREACH operation = operations %]
>+  [% FOREACH change = operation.changes %]
>+    [%  IF change.fieldname == 'cc' %]
>+      [% ccs_changed = 1 %]
>+      [% LAST %]
>+    [% END %]
>+  [% END %]
>+[% END %]

It would be more effecient to do this check in process_bug.cgi itself as you are looking for this field as part of bug 69447 already.

Comment 8

[David Lawrence [:dkl]]

Adding 64997 as a blocker. When that patch is committed I will use build on the code changes to move these checks to process_bug.cgi

dkl

Comment 9

[Frédéric Buclin]

Bugzilla 4.4 is now restricted to security fixes only.