303740 - Firefox offers to remember empty password

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050806
Firefox/1.0+

Steps to reproduce:
1. Load the testcase.
2. Enter a username but not a password.
3. Press Enter.

Result: Firefox offers to remember the password.

This is a problem for first-time users of buy.com and any other site that
follows Jakob Nielsen's recommendation regarding login pages at
http://useit.com/alertbox/20050725.html.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050806
Firefox/1.0+ ID:2005080615

Confirmed

i assume this isn't by design ?

any regressiondate ?

Comment 3

[Jesse Ruderman]

Also happens in a July 10 build, so it isn't a regression from the last few weeks.

Comment 4

[Jesse Ruderman]

Also happens in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050228 Firefox/1.0+ and in Firefox 1.0.4.  This isn't a recent
regression at all.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checked in on trunk.

Checking in nsPasswordManager.cpp;
/cvsroot/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,v 
<--  nsPasswordManager.cpp
new revision: 1.66; previous revision: 1.65
done

Comment 7

[Tracy Walker [:tracy]]

Looks good on Firefox Linux 2005-08-29-06-trunk

Comment 8

[Marcia Knous [:marcia]]

Same with Mac - Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1)
Gecko/20050829 Firefox/1.6a1

(In reply to comment #7)
> Looks good on Firefox Linux 2005-08-29-06-trunk

Comment 9

[Jay Patel [:jay]]

v.fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050829 Firefox/1.6a1.  We should get this onto the branch.

Comment 10

[Jesse Ruderman]

Checked in on Gecko 1.8 branch.

Checking in nsPasswordManager.cpp;
/cvsroot/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,v 
<--  nsPasswordManager.cpp
new revision: 1.65.2.2; previous revision: 1.65.2.1
done

Comment 11

[Tracy Walker [:tracy]]

verified on Firefox 1.4 -mozilla1.8 branch- Win, Lin and Mac : 2005-09-07